Feat: Added feature to show group names in the Client Details screen. #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarun0 @droidchef Please review this. |
moksh-mahajan
force-pushed
the
AddGroupToClientsScreen
branch
from
7e77583 to
a309196
Compare
tarun0
requested changes
Jun 15, 2019
...-android/src/main/java/com/mifos/mifosxdroid/online/clientdetails/ClientDetailsFragment.java
Outdated
Show resolved
Hide resolved
mifosng-android/src/main/java/com/mifos/objects/client/Client.java
Outdated
Show resolved
Hide resolved
moksh-mahajan
force-pushed
the
AddGroupToClientsScreen
branch
from
a309196 to
1cdacf4
Compare
|
@tarun0 I have made the requested changes. Please review |
|
Please resolve conflicts |
moksh-mahajan
force-pushed
the
AddGroupToClientsScreen
branch
from
1cdacf4 to
b8e503e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.