Add unit validation functionalities to validate() function #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianzwickl
requested review from
danielhuppmann,
erikfilias and
sandrinecharousset
sandrinecharousset
approved these changes
Nov 21, 2020
erikfilias
reviewed
Nov 21, 2020
Use f-strings instead of deprecated way. Co-authored-by: Daniel Huppmann <[email protected]>
Insert missing brackets
f' command and valid units read out
|
Excuse for inflationary commits. |
danielhuppmann
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the missing functionalities mentioned in #82 regarding the validation of units. In order to ensure an overview during the review process, I made no extension to the units (related to issue #83 and #76). Only a selected unit was added.