Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hydrogen SE and FE and gross trade SE #354

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

robertpietzcker
Copy link
Collaborator

Add gross trade values for electricity

Add liquids/gases from hydrogen to Secondary Energy when hydrogen is modelled as a commodity (see also discussion in IAMconsortium/common-definitions#106 (comment) )

Also add sub-variables for Curtailment for an analysis on storage/curtailment in ECEMF.

Also added centralized heat generation by heat pumps

@robertpietzcker
Copy link
Collaborator Author

@danielhuppmann would it be possible to merge this PR?

@robertpietzcker
Copy link
Collaborator Author

@danielhuppmann pushing this up again :-)

description: Total centralized heat generation from {Fuel}
unit: EJ/yr
- Secondary Energy|Heat|Electricity|Heat Pumps:
description: Total centralized heat generation from heat pumps ("Electricity" is already covered in {Fuel})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a copy-paste error with {Fuel}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I am failing to see the copy-paste error - could you clarify? @danielhuppmann

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a tag {Fuel} in the description but no corresponding tag in the variable name - and the whole second part of the description doesn’t make sense to me…

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to explain why there is an explicit Electricity|Heat Pumps version of the Secondary Energy|Heat| variable, but no explicit Electricity version - that one is already included in the {Fuel} version of Secondary Energy|Heat|.

But I can easily remove this explanation if you find it self-explanatory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don’t understand what you want to say. But in any case, please remove the curly brackets because are reserved for tags that are automatically replaced - and they can only be replaced if the same tag is present in the variable name itself.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know. I just updated it accordingly

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@danielhuppmann danielhuppmann merged commit c6eaaa2 into openENTRANCE:main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants