Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hydration parachain regression tests #32

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented Aug 23, 2024

We added our first regressions tests using the provided framework.

@xlc
Copy link
Member

xlc commented Sep 4, 2024

@dmoka do you want to finish this?

@dmoka
Copy link
Contributor Author

dmoka commented Sep 7, 2024

@dmoka do you want to finish this?

Absolutely, thanks for the patience, I had some higher prior stuff to work on last week. Early next week I will look into this and wrap it up

@dmoka
Copy link
Contributor Author

dmoka commented Sep 11, 2024

@xlc For one of our tests ('moonbeam transfer DOT to hydration'), we would need to create a new block on the toChain.

But in the runXtokenstHorizontal method, new block is only crated in the fromChain.

As a solution, we could add a new param to runXtokenstHorizontal, with a function type, with name postAction (or so) that we could easily execute there.

What do you think? Or you might have a better solution in mind?

@xlc
Copy link
Member

xlc commented Sep 11, 2024

Chopsticks should automatically create new blocks on a chain when it receives an incoming XCM so you shouldn't need to manually create new block unless you need an additional block beyond the automatically created one.
What is the reason you need it? For example if it is the auto new block for XCM isn't working well, that's something we can fix in Chopsticks.

@dmoka
Copy link
Contributor Author

dmoka commented Sep 16, 2024

Chopsticks should automatically create new blocks on a chain when it receives an incoming XCM so you shouldn't need to manually create new block unless you need an additional block beyond the automatically created one. What is the reason you need it? For example if it is the auto new block for XCM isn't working well, that's something we can fix in Chopsticks.

Hmm, now running it without using toChain.newBlock works well, the from and tochain balance checks are looking fine now. If you could double check it, that would be appreciated, otherwise LGTM from my point of view, thanks

@xlc xlc merged commit 26d22f4 into open-web3-stack:master Sep 16, 2024
11 checks passed
@dmoka dmoka deleted the test/add-hydration-tests branch September 17, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants