Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch potential logging related memory leak #2453

Closed
2 tasks done
smashah opened this issue Jan 31, 2022 · 2 comments
Closed
2 tasks done

patch potential logging related memory leak #2453

smashah opened this issue Jan 31, 2022 · 2 comments
Labels
PRIORITY Fast track for BMAC Members only.

Comments

@smashah
Copy link
Member

smashah commented Jan 31, 2022

If there are too many logs being emitted then it can cause the memory usage to grow infinitely.

winstonjs/winston#1871

  • patch winston
  • patch winston-transport
@owa-gh-bot owa-gh-bot bot added the PRIORITY Fast track for BMAC Members only. label Jan 31, 2022
smashah added a commit that referenced this issue Jan 31, 2022
@smashah
Copy link
Member Author

smashah commented Jan 31, 2022

@github-actions run

⚡ Release! ⚡
(async () => {
function exec(cmd) {
  console.log(execSync(cmd).toString());
}
//set the version type
process.env.VERS = "patch"

// Config
const gitUserEmail = "github-actions[bot]@users.noreply.github.com";
const gitUserName = "github-actions[bot]";

exec(`echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > .npmrc`);
exec(`git config --global user.email "${gitUserEmail}"`);
exec(`git config --global user.name "${gitUserName}"`);
exec(`npm i -D`);
exec(`npm run release-ci $VERS`);

// types only package
exec('npm config set //registry.npmjs.org/:_authToken $NPM_TOKEN')
exec(`cd ./types-only && npm version $VERS && npm run build && npm publish && cd ..`);
exec(`git commit -a -m 'updated types-only package'`);
exec(`git push --force`);

//comment on the issue
var result = execSync(`npx auto-changelog -o ./tempchangelog.txt --commit-limit false --template ./compact-keepachangelog.hbs --stdout`).toString();

    await postComment(result);

//create changelog image
exec(`npm run release-image`);
exec(`git commit -a -m 'updated release-image'`);
exec(`git push --force`);
  })();

@smashah
Copy link
Member Author

smashah commented Jan 31, 2022

Changelog

🚀 Release 4.30.10 (2022-01-31)

@smashah smashah closed this as completed Jan 31, 2022
@smashah smashah changed the title potential logging related memory leak patch potential logging related memory leak Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY Fast track for BMAC Members only.
Projects
None yet
Development

No branches or pull requests

1 participant