Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatible with latest model #563

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

compatible with latest model #563

wants to merge 10 commits into from

Conversation

desaimg1
Copy link
Contributor

Worked on following issues:

  1. Modified warnings as per latest model
  2. Added set_control_state and set_control_action as per the latest model
  3. Added get_version API

@desaimg1
Worked on following issues:
60e8713 
1. Modified warnings as per latest model
2. Added set_control_state and set_control_action as per the latest model
3. Added get_version API
Vibaswan
Vibaswan requested changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@Vibaswan Vibaswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also do not see a place where we have changed the snappi version to the new snappi version we are using, would you please point me to the right location where the change is there ?

snappi_ixnetwork/ping.py Show resolved Hide resolved
snappi_ixnetwork/ping.py Outdated Show resolved Hide resolved
snappi_ixnetwork/protocolmetrics.py Show resolved Hide resolved
snappi_ixnetwork/snappi_api.py Show resolved Hide resolved
Vibaswan
Vibaswan approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@Vibaswan Vibaswan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, Ci failing I guess as ports are not reachable
Adding @ashutshkumr for final review

@Vibaswan Vibaswan requested a review from ashutshkumr June 26, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vibaswan Vibaswan Vibaswan approved these changes

@ashutshkumr ashutshkumr Awaiting requested review from ashutshkumr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desaimg1 @Vibaswan @ashutshkumr