Model bgpsrte restruct #172
Conversation
SuryyaKrJana
requested review from
ankur-sheth,
ajbalogh,
anirbanb07,
apratimmukherjee,
ashutshkumr and
kingshukdev
and removed request for
kingshukdev
There was a problem hiding this comment.
In general , looks good to me. Only one attribute related clarification needed for local_preference i.e. whether we can have a default working mode for iBGP use-case which is the default and extra option to not include it optionally for eBGP. Rest are all related to descriptions.
|
What issue or enhancement is this PR addressing? Can we link the PR to it? And is this change backwards incompatible? |
https://github.com/open-traffic-generator/models/pull/154 |
There was a problem hiding this comment.
@SuryyaKrJana saw your comments. Answers my questions. I'm ok to take this in. You don't need to wait for my review. I would expect that BGP domain experts are reviewing in more detail.
Noted.
|
Hi
I think it might be better to start with known types.
If the concrete definition of the hex type is known , we can add that as needed later.
Is the hex value needed from RFC support point of view or is there some known use-case we can’t support without being able to specify hex values ?
Regards
Apratim
From: anirbanb07 ***@***.***>
Sent: 27 September 2021 08:04
To: open-traffic-generator/models ***@***.***>
Cc: Apratim Mukherjee ***@***.***>; Review requested ***@***.***>
Subject: Re: [open-traffic-generator/models] Model bgpsrte restruct (#172)
CAUTION: This message originates from an external sender.
@anirbanb07 commented on this pull request.
________________________________
In device/bgp/bgpexcommunity.yaml<https://urldefense.com/v3/__https:/github.com/open-traffic-generator/models/pull/172*discussion_r716320422__;Iw!!I5pVk4LIGAfnvw!zz6UcNsJkZAUMq6SfN6kdCTz2Zta4kPOMdEygq2k3asUP3jo4FFn8iAOzXHfAfo-oN1WC_yY$>:
+ - administrator_ipv4_address
+ - administrator_as_4octet
+ - opaque
+ - evpn
+ - administrator_as_2octet_link_bandwidth
+ subtype:
+ description: |-
+ Extended Community Sub Type field of 1 Byte.
+ - route_target: Route Target.
+ - origin: Origin.
+ - extended_bandwidth: Specifies the link bandwidth.
+ - color: Specifies the color value.
+ - encapsulation: Specifies the Encapsulation Extended Community.
+ - mac_address: Specifies the Extended community MAC address.
+ type: string
+ enum:
Can we have a provision here that user can enter any hex value here apart from these few types/subtypes?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/open-traffic-generator/models/pull/172*pullrequestreview-763791729__;Iw!!I5pVk4LIGAfnvw!zz6UcNsJkZAUMq6SfN6kdCTz2Zta4kPOMdEygq2k3asUP3jo4FFn8iAOzXHfAfo-oD4oW33U$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/ASZ6MO64PGXCH6PN4I5VRWTUD7J25ANCNFSM5EWSQPPA__;!!I5pVk4LIGAfnvw!zz6UcNsJkZAUMq6SfN6kdCTz2Zta4kPOMdEygq2k3asUP3jo4FFn8iAOzXHfAfo-oFxqlqZu$>.
Triage notifications on the go with GitHub Mobile for iOS<https://urldefense.com/v3/__https:/apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!I5pVk4LIGAfnvw!zz6UcNsJkZAUMq6SfN6kdCTz2Zta4kPOMdEygq2k3asUP3jo4FFn8iAOzXHfAfo-oKKD50U5$> or Android<https://urldefense.com/v3/__https:/play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!I5pVk4LIGAfnvw!zz6UcNsJkZAUMq6SfN6kdCTz2Zta4kPOMdEygq2k3asUP3jo4FFn8iAOzXHfAfo-oA-Up0JW$>.
|
…ement changed the input format to hex
…ement changed the input format to hex
|
@ajbalogh do you have any ideas on how to fix multiline comments involving bullets ? In redocly they all seem to appear as a single line making it harder to read the text. Maybe we could work out some rule for writing descriptions (and enhance bundler accordingly) ? |
|
@ashutshkumr I agree we should come up with a standard for representing descriptions. |
https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/open-traffic-generator/models/model_bgpsrte_restruct/artifacts/openapi.yaml
While working PR#154 at the end , we have found SRTE needs a refactoring a bit. We discussed in the scrum and found no body right now using SRTE model. All agreed to disable in SRTE from top level (BGP Peer) and merged PR#154 to master to progress Controller and Rustic working together. That’s testing is going on. Btw, I have created another PR#172 for SRTE Model modification. It is backward compatible to PR#154.
Previous PR: https://github.com/open-traffic-generator/models/pull/154
#Snappi and Json code examples.
{ "devices": [ { "ethernets": [ { "ipv4_addresses": [ { "address": "20.20.20.2", "gateway": "20.20.20.1", "name": "p1_ip1", "prefix": 24 }, { "address": "30.30.30.2", "gateway": "30.30.30.1", "name": "p2_ip1", "prefix": 24 } ], "mac": "64:00:00:00:00:01", "mtu": 1500, "name": "p1_eth1", "port_name": "p1", "vlans": [ { "id": 100, "name": "p1_vlan1", "priority": 0, "tpid": "x8100" } ] } ], "ipv4_loopbacks": [ { "address": "1.1.1.1", "eth_name": "p1_eth1", "name": "p1_lo1" } ], "isis": { "advanced": { "area_addresses": [ "490001", "490002" ], "csnp_interval": 10000, "enable_hello_padding": true, "lsp_lifetime": 1200, "lsp_mgroup_min_trans_interval": 5000, "lsp_refresh_rate": 600, "max_area_addresses": 3, "max_lsp_size": 1492, "psnp_interval": 2000 }, "interfaces": [ { "eth_name": "p1_eth1", "l2_settings": { "dead_interval": 30, "hello_interval": 1000, "priority": 100 }, "level_type": "level_2", "link_protection": { "dedicated_1_plus_1": false, "dedicated_1_to_1": false, "enhanced": false, "extra_traffic": false, "reserved_40": false, "reserved_80": false, "shared": true, "unprotected": false }, "metric": 10, "multi_topology_ids": [ { "link_metric": 20, "mt_id": 2 } ], "network_type": "broadcast", "traffic_engineering": [ { "administrative_group": "0100000", "max_bandwith": 125000000, "max_reservable_bandwidth": 125000000, "metric_level": 20, "priority_bandwidths_0_7": { "pb0": 2500000, "pb1": 2550000, "pb2": 125000000, "pb3": 125000000, "pb4": 125000000, "pb5": 125000000, "pb6": 125000000, "pb7": 125000000 } } ] } ], "name": "p1_d1_isis", "system_id": "640000000001", "v4_routes": [ { "addresses": [ { "address": "1.1.1.1", "count": 1, "prefix": 32, "step": 1 } ], "link_metric": 0, "n_flag": false, "name": "rr1", "r_flag": false, "redistribution": "up", "route_origin": "internal", "x_flag": false } ] }, "name": "p1_d1" }, { "bgp": { "ipv4_interfaces": [ { "ipv4_name": "p1_lo1", "peers": [ { "as_number": 100, "as_number_width": "four", "as_type": "ibgp", "capability": { "evpn": false, "extended_next_hop_encoding": false, "ipv4_mdt": false, "ipv4_mpls_vpn": false, "ipv4_multicast": false, "ipv4_multicast_mpls_vpn": false, "ipv4_multicast_vpn": false, "ipv4_sr_te_policy": true, "ipv4_unicast": true, "ipv4_unicast_add_path": false, "ipv4_unicast_flow_spec": false, "ipv6_mdt": false, "ipv6_mpls_vpn": false, "ipv6_multicast": false, "ipv6_multicast_mpls_vpn": false, "ipv6_multicast_vpn": false, "ipv6_sr_te_policy": false, "ipv6_unicast": true, "ipv6_unicast_add_path": false, "ipv6_unicast_flow_spec": false, "link_state_non_vpn": false, "link_state_vpn": false, "route_constraint": false, "route_refresh": true, "vpls": false }, "name": "p1_peer1", "peer_address": "10.10.10.10", "v4_routes": [ { "addresses": [ { "address": "100.10.1.1", "count": 2, "prefix": 24, "step": 2 } ], "name": "p1_rr1", "next_hop_address_type": "ipv4", "next_hop_ipv4_address": "0.0.0.0", "next_hop_ipv6_address": "::0", "next_hop_mode": "local_ip" } ], "v4_srte_policies": [ { "active": true, "color": 100, "distinguisher": 1, "ipv4_endpoint": "100.100.10.1", "name": "policy1", "next_hop_address_type": "ipv4", "next_hop_mode": "local_ip", "tunnel_tlvs": [ { "active": true, "name": "tunnel1", "policy_name_sub_tlv": { "policy_name": "srte_test" }, "policy_priority_sub_tlv": { "policy_priority": 100 }, "segment_lists": [ { "active": true, "name": "segmentlis1", "segments": [ { "active": true, "name": "seg-1", "segment_type": "type_a", "type_a": { "flags": 0, "label": 1000 } }, { "active": true, "name": "seg1", "segment_type": "type_a", "type_a": { "flags": 0, "label": 2000 } } ] } ] } ] } ], "v6_routes": [ { "addresses": [ { "address": "1000:1:1:1::1", "count": 2, "prefix": 56, "step": 2 } ], "name": "p1_rr2", "next_hop_address_type": "ipv6", "next_hop_ipv4_address": "0.0.0.0", "next_hop_ipv6_address": "::0", "next_hop_mode": "manual" } ] } ] } ], "router_id": "1.1.1.1" }, "name": "p1_unconn" }, { "ethernets": [ { "mac": "65:00:00:00:00:01", "mtu": 1500, "name": "p2_eth1", "port_name": "p2", "vlans": [ { "id": 100, "name": "p2_vlan1", "priority": 0, "tpid": "x8100" } ] } ], "isis": { "interfaces": [ { "eth_name": "p2_eth1", "level_type": "level_2", "link_protection": { "dedicated_1_plus_1": false, "dedicated_1_to_1": false, "enhanced": false, "extra_traffic": false, "reserved_40": false, "reserved_80": false, "shared": false, "unprotected": false }, "metric": 10, "network_type": "broadcast" } ], "name": "p2_d1_isis", "system_id": "650000000001", "v4_routes": [ { "addresses": [ { "address": "2.2.2.2", "count": 1, "prefix": 32, "step": 1 } ], "link_metric": 0, "n_flag": false, "name": "p2_rr1", "r_flag": false, "redistribution": "up", "route_origin": "internal", "x_flag": false } ] }, "name": "p2_d1" }, { "bgp": { "ipv4_interfaces": [ { "ipv4_name": "p2_lo1", "peers": [ { "as_number": 100, "as_number_width": "four", "as_type": "ibgp", "capability": { "evpn": false, "extended_next_hop_encoding": false, "ipv4_mdt": false, "ipv4_mpls_vpn": false, "ipv4_multicast": false, "ipv4_multicast_mpls_vpn": false, "ipv4_multicast_vpn": false, "ipv4_sr_te_policy": true, "ipv4_unicast": true, "ipv4_unicast_add_path": false, "ipv4_unicast_flow_spec": false, "ipv6_mdt": false, "ipv6_mpls_vpn": false, "ipv6_multicast": false, "ipv6_multicast_mpls_vpn": false, "ipv6_multicast_vpn": false, "ipv6_sr_te_policy": false, "ipv6_unicast": true, "ipv6_unicast_add_path": false, "ipv6_unicast_flow_spec": false, "link_state_non_vpn": false, "link_state_vpn": false, "route_constraint": false, "route_refresh": true, "vpls": false }, "name": "p2_peer1", "peer_address": "10.10.10.10", "v4_routes": [ { "addresses": [ { "address": "200.10.1.1", "count": 2, "prefix": 24, "step": 2 } ], "name": "p2_rr1", "next_hop_address_type": "ipv4", "next_hop_ipv4_address": "0.0.0.0", "next_hop_ipv6_address": "::0", "next_hop_mode": "local_ip" } ], "v6_routes": [ { "addresses": [ { "address": "2000:1:1:1::1", "count": 2, "prefix": 64, "step": 2 } ], "name": "p2_rr2", "next_hop_address_type": "ipv6", "next_hop_ipv4_address": "0.0.0.0", "next_hop_ipv6_address": "::0", "next_hop_mode": "local_ip" } ] } ] } ], "router_id": "2.2.2.2" }, "ipv4_loopbacks": [ { "address": "2.2.2.2", "eth_name": "p2_eth1", "name": "p2_lo1" } ], "name": "p2_unconn" } ], "flows": [ { "name": "f1", "tx_rx": { "choice": "device", "device": { "mode": "mesh", "rx_names": [ "p2_rr1", "p2_rr2" ], "tx_names": [ "p1_rr1", "p1_rr2" ] } } } ], "ports": [ { "location": "172.17.0.2:50071", "name": "p1" }, { "location": "172.17.0.3:50071", "name": "p2" } ] } { "state": "stop" }