[chore] Move metric requirement levels doc from spec #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified the wording and deleted a phrase, which doesn't seem to add anything useful to the text.
…r protocol (#2602)
Add semantic conventions for GraphQL span name and attributes. Related issues open-telemetry#1670
OTEL-PHP at some point switched to using InstrumentationScope instead of InstrumentationLibrary everywhere, which incidentally satisfied the ["Fetch InstrumentationScope from ReadableSpan"](https://github.com/open-telemetry/opentelemetry-specification/blob/9abbdd39d0b35f635f833f072013431da419894e/specification/common/mapping-to-non-otlp.md#instrumentationscope) part of the spec (otel-php is still alpha so it seemed ok to not deprecate the instrumentation library and just remove it's use entirely) Related issues # open-telemetry/opentelemetry-php#705 Related [OTEP(s)](https://github.com/open-telemetry/oteps) # Don't think it was an OTEP but open-telemetry/opentelemetry-specification#2276 is where the push for the change originally came from I believe
Co-authored-by: Tigran Najaryan <[email protected]>
…commended (#2627)
* Update aws lambda spec to remove X-Ray Env propagation Per discussion in the FAAS SIG, we decided that the aws x-ray environment variable should be moved to a span link to avoid interfering with the configured propagators.
…cification (#3171)
* getting rid of double negation * Update specification/logs/semantic_conventions/events.md Co-authored-by: Yuri Shkuro <[email protected]> --------- Co-authored-by: Yuri Shkuro <[email protected]>
We keep seeing confusion about what Logs API is. There was a proposal [1] to use the term Bridge API to help prevent the confusion. Please take a look and comment on whether you think this renaming helps and is reasonable. [1] open-telemetry/opentelemetry-specification#3187 (comment)
Co-authored-by: Carlos Alberto Cortez <[email protected]>
…`faas.max_memory` (#3209)
* Add connect_rpc to rpc.yaml * Add connect rpc into rpc-metrics and rpc markdown * Add Connect RPC change to CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
|
|
|
We will have to do the same when merging this one as done in #493 (comment). Not sure what to do about the CLA check 😕 |
|
or maybe I didn't bring the history correctly after all 😬 . Will try again 🔁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822
Changes
Moves the metric requirement levels document to the semconv repo.
I think I managed to get the git history correct.
Merge requirement checklist
[chore]