-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(messaging): add gcp_pubsub unary pull example #634
Conversation
Co-authored-by: Joao Grassi <[email protected]>
Left a few minor comments. It's mostly good to go, but the recent addition of Also checking if @jsuereth wants to take a look from Google Cloud perspective. |
Thank you for all the reviews-- sorry it took so long! I removed the project.id for now. We can add it in a separate PR. |
@alevenberg thank you! BTW, we've recently introduced |
Part of #527
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Used
make table-generation && make fix && make markdownlint && yamllint
Merge requirement checklist