Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(messaging): add gcp_pubsub unary pull example #634

Merged
merged 40 commits into from
Apr 24, 2024

Conversation

alevenberg
Copy link
Contributor

@alevenberg alevenberg commented Jan 10, 2024

Part of #527

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Used make table-generation && make fix && make markdownlint && yamllint

Merge requirement checklist

docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
@alevenberg alevenberg marked this pull request as ready for review January 10, 2024 15:58
@alevenberg alevenberg requested review from a team January 10, 2024 15:58
docs/messaging/gcp-pubsub.md Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
model/registry/messaging.yaml Show resolved Hide resolved
model/trace/messaging.yaml Outdated Show resolved Hide resolved
docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
docs/messaging/gcp-pubsub.md Outdated Show resolved Hide resolved
.chloggen/634.yaml Outdated Show resolved Hide resolved
docs/attributes-registry/messaging.md Outdated Show resolved Hide resolved
model/resource/cloud_provider/gcp/project.yaml Outdated Show resolved Hide resolved
model/resource/cloud_provider/gcp/project.yaml Outdated Show resolved Hide resolved
model/trace/messaging.yaml Show resolved Hide resolved
model/registry/gcp.yaml Outdated Show resolved Hide resolved
.chloggen/634.yaml Outdated Show resolved Hide resolved
@lmolkova
Copy link
Contributor

Left a few minor comments.

It's mostly good to go, but the recent addition of gcp.project.id needs a bit more polishing.
Alternatively, I'm happy to approve if the introduction of the gcp.project.id is removed and done in a separate PR.

Also checking if @jsuereth wants to take a look from Google Cloud perspective.

@alevenberg
Copy link
Contributor Author

Left a few minor comments.

It's mostly good to go, but the recent addition of gcp.project.id needs a bit more polishing. Alternatively, I'm happy to approve if the introduction of the gcp.project.id is removed and done in a separate PR.

Also checking if @jsuereth wants to take a look from Google Cloud perspective.

Thank you for all the reviews-- sorry it took so long!

I removed the project.id for now. We can add it in a separate PR.

@lmolkova
Copy link
Contributor

@alevenberg thank you!

BTW, we've recently introduced messaging.operation.name attribute which you can now also use to define GCP pubsub-specific operations more formally. This is not a blocker for this PR for sure.

docs/messaging/gcp-pubsub.md Show resolved Hide resolved
@lmolkova lmolkova merged commit 387b74f into open-telemetry:main Apr 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants