Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename process.runtime.jvm.cpu.utilization to process.runtime.jvm.cpu.recent_utilization #53

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

trask
Copy link
Member

@trask trask commented May 25, 2023

Fixes #42

Renames process.runtime.jvm.cpu.utilization to process.runtime.jvm.cpu.recent_utilization to make it clear that this is not "utilization since last measurement" (or "utilization since start").

@trask trask force-pushed the recent-utilization branch from 3052f6f to 7fc2a43 Compare May 25, 2023 23:43
@trask trask force-pushed the recent-utilization branch from 7fc2a43 to fd23c97 Compare May 25, 2023 23:44
@trask trask marked this pull request as ready for review May 25, 2023 23:48
@trask trask requested review from a team May 25, 2023 23:48
@mateuszrzeszutek
Copy link
Member

Shouldn't you add the rename to the schema file?

@trask trask requested a review from tigrannajaryan as a code owner May 26, 2023 13:46
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema file LGTM.

@trask
Copy link
Member Author

trask commented Jun 7, 2023

@open-telemetry/specs-semconv-maintainers I think this is ready to merge now, thx

@reyang reyang merged commit 412a3ef into open-telemetry:main Jun 9, 2023
@trask trask deleted the recent-utilization branch October 14, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename process.runtime.jvm.cpu.utilization to process.runtime.jvm.cpu.recent_utilization
8 participants