-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how to report the total amount of memory #409
Clarify how to report the total amount of memory #409
Conversation
f0d46c3
to
b862a39
Compare
b862a39
to
aac8c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a bug to provide a mechanism in Schema-Files to denote an attribute being dropped?
Yes, it's a breaking change, we're actually going to try to encode breaking changes in SCHEMA over time.
#1054 is related (although it refers to a different instance where the values were renamed, not dropped). Does that work? Or should we file a new one? |
I think this can be a non-breaking change:
We can define a |
Adds opt-in support for `system.memory.limit`, standardized on open-telemetry/semantic-conventions/pull/409.
…#30306) Adds opt-in support for `system.memory.limit`, standardized on open-telemetry/semantic-conventions/pull/409.
Updates open-telemetry/build-tools#127
Changes
total
from list of well-known values forsystem.memory.state
system.memory.usage
clarifying that adding oversystem.memory.state
SHOULD equal the total amount of memory available in the system.system.memory.limit
metric that reports the total amount of memory available in the system.This tries to follow the guidance on https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md#instrument-naming:
and
The
total
value was added on open-telemetry/build-tools#89 but was not listed before the refactoring. This rewording avoids an inconsistency with the general guidelines and adds a metric that may be useful in some implementations given that total is reported separately by certain OSs (e.g. Linux).Merge requirement checklist