-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container semantic conventions resource #39
Merged
jsuereth
merged 10 commits into
open-telemetry:main
from
marcsanmi:add-spec-resource-container-attributes
Jun 28, 2023
Merged
Add container semantic conventions resource #39
jsuereth
merged 10 commits into
open-telemetry:main
from
marcsanmi:add-spec-resource-container-attributes
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
reviewed
May 23, 2023
lmolkova
requested changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose following OCI spec terminology - left a comment on it.
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
2 times, most recently
from
May 26, 2023 08:04
07d4faa
to
ac909d7
Compare
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
from
June 9, 2023 12:37
ac909d7
to
5d80f9f
Compare
lmolkova
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
from
June 14, 2023 16:01
5d80f9f
to
da791f2
Compare
lmolkova
reviewed
Jun 14, 2023
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
from
June 16, 2023 09:57
1845233
to
5a50078
Compare
joaopgrassi
reviewed
Jun 16, 2023
@marcsanmi please also add a changelog entry |
joaopgrassi
reviewed
Jun 19, 2023
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
2 times, most recently
from
June 22, 2023 07:32
1d40cf6
to
a1df09f
Compare
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
2 times, most recently
from
June 26, 2023 07:01
400f821
to
1375c8c
Compare
joaopgrassi
approved these changes
Jun 26, 2023
ChrsMark
approved these changes
Jun 27, 2023
marcsanmi
force-pushed
the
add-spec-resource-container-attributes
branch
from
June 27, 2023 14:30
4a6d8f5
to
ea16261
Compare
jsuereth
approved these changes
Jun 28, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-telemetry/opentelemetry-specification#3468.