Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container semantic conventions resource #39

Merged

Conversation

marcsanmi
Copy link
Contributor

@marcsanmi marcsanmi commented May 18, 2023

@marcsanmi marcsanmi requested review from a team May 18, 2023 10:35
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose following OCI spec terminology - left a comment on it.

semantic_conventions/resource/container.yaml Show resolved Hide resolved
semantic_conventions/resource/container.yaml Outdated Show resolved Hide resolved
@marcsanmi marcsanmi force-pushed the add-spec-resource-container-attributes branch 2 times, most recently from 07d4faa to ac909d7 Compare May 26, 2023 08:04
@marcsanmi marcsanmi force-pushed the add-spec-resource-container-attributes branch from ac909d7 to 5d80f9f Compare June 9, 2023 12:37
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcsanmi marcsanmi force-pushed the add-spec-resource-container-attributes branch from 5d80f9f to da791f2 Compare June 14, 2023 16:01
@marcsanmi marcsanmi force-pushed the add-spec-resource-container-attributes branch from 1845233 to 5a50078 Compare June 16, 2023 09:57
@joaopgrassi
Copy link
Member

@marcsanmi please also add a changelog entry

CHANGELOG.md Outdated Show resolved Hide resolved
@marcsanmi marcsanmi force-pushed the add-spec-resource-container-attributes branch from 4a6d8f5 to ea16261 Compare June 27, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants