Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Update build-tools to 0.22.0 and sort attributes alphabetically in all semconv #359

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Editorial: Update build-tools to 0.22.0 and sort attributes alphabetically in all semconv #359

merged 2 commits into from
Oct 3, 2023

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 2, 2023 •
edited
Loading

Changes

Update to new build-tools 0.22.0 which:

  • sorts attribute alphabetically in semconv tables
  • inherits ref properties (only the original definition was used before)

Merge requirement checklist

@lmolkova lmolkova requested review from a team October 2, 2023 16:25
@lmolkova lmolkova requested a review from a team October 2, 2023 16:25
@lmolkova lmolkova mentioned this pull request Oct 2, 2023
Closed
@joaopgrassi joaopgrassi merged commit 2c065be into open-telemetry:main Oct 3, 2023
8 checks passed
breedx-splk pushed a commit to breedx-splk/semantic-conventions that referenced this pull request Oct 3, 2023
@lmolkova @arminru @breedx-splk
Editorial: Update build-tools to 0.22.0 and sort attributes alphabeti…
34bca22 
…cally in all semconv (open-telemetry#359)

Co-authored-by: Armin Ruech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@arminru arminru arminru approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

@trask trask trask approved these changes

@jsuereth jsuereth jsuereth approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lmolkova @jsuereth @trask @jonatan-ivanov @joaopgrassi @arminru @reyang