Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System metrics yaml warning #322

Conversation

joaopgrassi
Copy link
Member

I noticed a warning in PRs related to the recently merged #89 yaml model for system metrics. I left a misaligned comment and GitHub UI complains about it:

image

@joaopgrassi joaopgrassi requested review from a team September 13, 2023 10:41
@joaopgrassi joaopgrassi changed the title Fix System metrics yaml warnings Fix System metrics yaml warning Sep 13, 2023
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@joaopgrassi joaopgrassi merged commit e880bdd into open-telemetry:main Sep 13, 2023
9 checks passed
@joaopgrassi joaopgrassi deleted the fix-system-metricsy-yaml branch September 13, 2023 11:11
trask pushed a commit to trask/semantic-conventions that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants