Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.github/CODEOWNERS] Add semconv system approvers #309

Merged
merged 2 commits into from
Sep 11, 2023
Merged

[.github/CODEOWNERS] Add semconv system approvers #309

merged 2 commits into from
Sep 11, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 11, 2023

Changes

Fixes #294

Adds system semantic conventions approvers for:

  1. system. metrics
  2. host. resource attributes

@mx-psi mx-psi marked this pull request as ready for review September 11, 2023 12:56
@mx-psi mx-psi requested review from a team September 11, 2023 12:56
@mx-psi mx-psi mentioned this pull request Sep 11, 2023
Closed
frzifus
frzifus approved these changes Sep 11, 2023
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
@jsuereth jsuereth merged commit db3a9aa into open-telemetry:main Sep 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@frzifus frzifus frzifus approved these changes

@arminru arminru arminru approved these changes

@dmitryax dmitryax dmitryax approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to create semconv-system-approver
8 participants
@mx-psi @AlexanderWert @joaopgrassi @dmitryax @arminru @frzifus @reyang @jsuereth