-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update process.runtime
example for the Python language
#1772
Conversation
Thanks for the PR!
What would be the benefit of using |
There's no real benefit in using I believe it's still best to keep Just wanted to double check that we still want to stick to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's still best to keep
sys.implementation.version
, as coupled withprocess.runtime.name
, we know exactly which PyPy version was used and getting the Python implementation version used by this PyPy version is just a matter of looking up online at downloads.python.org/pypy. If we were to usesys.version_info
, we would be missing the exact PyPy version (e.g. PyPy 7.3.16 and 7.3.17 both use Python 3.10.14).Just wanted to double check that we still want to stick to
sys.implementation.version
This makes sense to me. LGTM
cc @open-telemetry/python-approvers |
process.runtime
exampleprocess.runtime
example for the Python language
Changes
The Python runtimes specification says:
The PyPy example currently uses version 7.3.2 (4 years old). In this version, it seems that PyPy did not implement
sys.implementation.version
correctly:sys.implementation.version
documentation:In the latest PyPy release (7.3.17), this was fixed:
So the example was fixed accordingly. However, Is this expected? Should
sys.version_info
be used instead?Merge requirement checklist
[chore]