Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds mistral_ai as a gen_ai.system attribute value #1719

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Adds mistral_ai as a gen_ai.system attribute value #1719

merged 5 commits into from
Jan 9, 2025

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Jan 3, 2025 •
edited
Loading

This extends GenAI System to include Mistral AI. This accessed either via its native 'mistralai' API or via OpenAI libraries.

This is a follow-up to #1655

Changes

Added the following:

  • "mistral_ai", not "mistralai" to adhere to conventions suggested by @trask and @lmolkova

Merge requirement checklist

@codefromthecrypt codefromthecrypt requested review from a team as code owners January 3, 2025 23:17
@codefromthecrypt codefromthecrypt mentioned this pull request Jan 3, 2025
Merged
3 tasks
drewby
drewby approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@drewby drewby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition looks good to me.

lmolkova
lmolkova reviewed Jan 6, 2025
View reviewed changes
model/gen-ai/registry.yaml Outdated Show resolved Hide resolved
@lmolkova lmolkova enabled auto-merge (squash) January 8, 2025 02:32
@trask trask disabled auto-merge January 8, 2025 03:02
@codefromthecrypt @lmolkova
Update model/gen-ai/registry.yaml
61f6b56 
Co-authored-by: Liudmila Molkova <[email protected]>
@codefromthecrypt codefromthecrypt changed the title Adds mistralai as a gen_ai.system attribute value Adds mistral_ai as a gen_ai.system attribute value Jan 8, 2025
@codefromthecrypt
case format
64be327 
Signed-off-by: Adrian Cole <[email protected]>
@gyliu513 gyliu513 mentioned this pull request Jan 8, 2025
Closed
3 tasks
@joaopgrassi joaopgrassi merged commit 65f3f8f into open-telemetry:main Jan 9, 2025
14 checks passed
@codefromthecrypt codefromthecrypt deleted the mistralai branch January 18, 2025 17:15
lmolkova added a commit to lmolkova/semantic-conventions that referenced this pull request Jan 21, 2025
@codefromthecrypt @lmolkova @joaopgrassi
Adds mistral_ai as a gen_ai.system attribute value (open-telemetr…
1451e56 
…y#1719)

Signed-off-by: Adrian Cole <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisch-me trisch-me trisch-me left review comments

@gyliu513 gyliu513 gyliu513 left review comments

@lmolkova lmolkova lmolkova approved these changes

@trask trask trask approved these changes

@drewby drewby drewby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codefromthecrypt @drewby @trask @lmolkova @gyliu513 @trisch-me @joaopgrassi