Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement_level usages from registry and add a policy to check #1606

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 22, 2024

Requirement levels should only appear on spans/metrics/events/profiles definitions. They are not rendered on the registry attributes and make no sense there.

Related: #1603 (comment)

@lmolkova lmolkova added tooling Regarding build, workflows, build-tools, ... Skip Changelog Label to skip the changelog check labels Nov 22, 2024
@lmolkova lmolkova requested review from a team as code owners November 22, 2024 19:42
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsuereth jsuereth merged commit 03e1ba0 into open-telemetry:main Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check tooling Regarding build, workflows, build-tools, ...
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants