Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define semantic convention group and mixed stability rules #1472

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Define semantic convention group and mixed stability rules #1472

merged 9 commits into from
Oct 24, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Oct 13, 2024 •
edited
Loading

Fixes #906.

Related: #1423

Key points:

  • Allow stable groups with experimental attributes (as opt-in)
  • Document some rules around it

Merge requirement checklist

@lmolkova lmolkova mentioned this pull request Oct 16, 2024
Merged
3 tasks
@lmolkova lmolkova mentioned this pull request Oct 17, 2024
Merged
@lmolkova lmolkova mentioned this pull request Oct 23, 2024
Merged
@lmolkova lmolkova changed the title [WIP] Define semantic convention group and mixed stability rules Define semantic convention group and mixed stability rules Oct 24, 2024
@lmolkova lmolkova marked this pull request as ready for review October 24, 2024 01:25
@lmolkova lmolkova requested review from a team as code owners October 24, 2024 01:25
@lmolkova lmolkova mentioned this pull request Oct 24, 2024
Open
lquerel
lquerel approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

trask
trask approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approving specifically for the yaml and md files, didn't review the rego files)

docs/general/group-stability.md Outdated Show resolved Hide resolved
docs/http/http-metrics.md Show resolved Hide resolved
@lmolkova lmolkova merged commit d9d1e21 into open-telemetry:main Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquerel lquerel lquerel approved these changes

@trask trask trask approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should there be any attributes marked as stable inside of experimental conventions?
4 participants
@lmolkova @jsuereth @trask @lquerel