-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved general semantic conventions markdown to a topic folder. #143
Moved general semantic conventions markdown to a topic folder. #143
Conversation
8f6ee08
to
624136b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me. Will do another pass once #141 is merged since it will be easier/less changed files then 👍
624136b
to
aa02ca0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall Looks good.
One change needed though - Can you update "Logging" codeowners (tigran) so that the new "general" event/log semantic conventions will ping him for review?
Done. |
2aa586f
to
1abfedc
Compare
291361e
to
10a8b95
Compare
430616e
to
7c0d58f
Compare
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
Signed-off-by: Alexander Wert <[email protected]>
7c0d58f
to
36c4093
Compare
Part of #137
Depends on #141