Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved general semantic conventions markdown to a topic folder. #143

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

AlexanderWert
Copy link
Member

Part of #137

Depends on #141

@AlexanderWert AlexanderWert requested review from a team June 28, 2023 09:06
@AlexanderWert AlexanderWert force-pushed the md-restruct-general branch 3 times, most recently from 8f6ee08 to 624136b Compare June 28, 2023 09:28
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. Will do another pass once #141 is merged since it will be easier/less changed files then 👍

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Looks good.

One change needed though - Can you update "Logging" codeowners (tigran) so that the new "general" event/log semantic conventions will ping him for review?

@AlexanderWert
Copy link
Member Author

Overall Looks good.

One change needed though - Can you update "Logging" codeowners (tigran) so that the new "general" event/log semantic conventions will ping him for review?

Done.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@reyang reyang merged commit 2d1ea6b into open-telemetry:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants