Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define sanitization for db.query.text #1100

Merged
merged 17 commits into from
Jun 24, 2024
Merged

Define sanitization for db.query.text #1100

merged 17 commits into from
Jun 24, 2024

Conversation

gregkalapos
Copy link
Member

Fixes #717

Changes

Describes how to sanitize db.query.text.

Merge requirement checklist

@gregkalapos gregkalapos marked this pull request as ready for review May 31, 2024 17:23
@gregkalapos gregkalapos requested review from a team May 31, 2024 17:23
lmolkova
lmolkova reviewed Jun 3, 2024
View reviewed changes
docs/database/cosmosdb.md Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Jun 3, 2024
View reviewed changes
docs/database/cosmosdb.md Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Jun 7, 2024
View reviewed changes
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
trask
trask reviewed Jun 19, 2024
View reviewed changes
docs/database/database-spans.md Outdated Show resolved Hide resolved
docs/database/database-spans.md Outdated Show resolved Hide resolved
model/trace/database.yaml Outdated Show resolved Hide resolved
gregkalapos and others added 3 commits June 21, 2024 15:40
@gregkalapos @trask
Apply suggestions from code review
f53180e 
Co-authored-by: Trask Stalnaker <[email protected]>
@gregkalapos
Move db.query.text note to registry
4db101b 
and inherit requirement_level in trace.db.common.query_and_collection from attributes.db.client.minimal
@gregkalapos
Update db.md
cc931e2
@trask trask mentioned this pull request Jun 21, 2024
Open
@lmolkova lmolkova mentioned this pull request Jun 24, 2024
Open
@lmolkova lmolkova merged commit eeed399 into open-telemetry:main Jun 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@maryliag maryliag maryliag approved these changes

@matt-hensley matt-hensley matt-hensley left review comments

@trask trask trask approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Database Client Semantic Conventions
Status: Done
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB sanitization uniform format
6 participants
@gregkalapos @matt-hensley @trask @maryliag @lmolkova @arminru