Skip to content

Commit

Permalink
Remove outdated note about not recording HTTP server.address when o…
Browse files Browse the repository at this point in the history
…nly IP address available (#413)

Co-authored-by: Joao Grassi <[email protected]>
  • Loading branch information
trask and joaopgrassi authored Oct 18, 2023
1 parent 67e5c98 commit d75bb84
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 16 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ release.
([#399](https://github.com/open-telemetry/semantic-conventions/pull/399))
- Add cardinality warning about two opt-in HTTP metric attributes to all HTTP metrics.
([#412](https://github.com/open-telemetry/semantic-conventions/pull/412))
- Remove outdated note about not recording HTTP `server.address` when only IP address available.
([#413](https://github.com/open-telemetry/semantic-conventions/pull/413))

## v1.22.0 (2023-10-12)

Expand Down
8 changes: 0 additions & 8 deletions docs/http/http-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
if it's sent in absolute-form.
- Host identifier of the `Host` header

SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.

Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.

Expand Down Expand Up @@ -215,8 +213,6 @@ Tracing instrumentations that do so, MUST also set `http.request.method_original
if it's sent in absolute-form.
- Host identifier of the `Host` header

SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.

Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.

Expand Down Expand Up @@ -320,8 +316,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
if it's sent in absolute-form.
- Host identifier of the `Host` header

SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.

Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.

Expand Down Expand Up @@ -433,8 +427,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
if it's sent in absolute-form.
- Host identifier of the `Host` header

SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.

Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.

Expand Down
2 changes: 0 additions & 2 deletions docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,6 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
if it's sent in absolute-form.
- Host identifier of the `Host` header

SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.

**[5]:** Determined by using the first of the following that applies

- Port identifier of the [primary server host](/docs/http/http-spans.md#http-server-definitions) of the matched virtual host.
Expand Down
2 changes: 0 additions & 2 deletions model/http-common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ groups:
if it's sent in absolute-form.
- Host identifier of the `Host` header
SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
- ref: server.port
brief: >
Port of the local HTTP server that received the request.
Expand Down
4 changes: 0 additions & 4 deletions model/metrics/http.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ groups:
if it's sent in absolute-form.
- Host identifier of the `Host` header
SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.
Expand Down Expand Up @@ -74,8 +72,6 @@ groups:
if it's sent in absolute-form.
- Host identifier of the `Host` header
SHOULD NOT be set if only IP address is available and capturing name would require a reverse DNS lookup.
Warning: since this attribute may be based on the `Host` header, opting in to it may allow an attacker
to trigger cardinality limits, degrading the usefulness of the metric.
Expand Down

0 comments on commit d75bb84

Please sign in to comment.