Skip to content

Commit

Permalink
further clarified collector and containers
Browse files Browse the repository at this point in the history
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
  • Loading branch information
jpkrohling committed Feb 22, 2024
1 parent bcbf475 commit 6b8421c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/resource/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ thread in unicorn) to have its own instance.id.

It's not recommended for a Collector to set `service.instance.id` if it can't unambiguously determine the
service instance that is generating that telemetry. For instance, creating an UUID based on `pod.name` will
likely be wrong, as the Collector likely doesn't know whether there are multiple containers within that pod.
likely be wrong, as the Collector might not know from which container within that pod the telemetry originated.
However, Collectors can set the `service.instance.id` if they can unambiguously determine the service instance
for that telemetry. This is typically the case for scraping receivers, as they know the target address and
port.
Expand Down
2 changes: 1 addition & 1 deletion model/resource/service_experimental.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ groups:
It's not recommended for a Collector to set `service.instance.id` if it can't unambiguously determine the
service instance that is generating that telemetry. For instance, creating an UUID based on `pod.name` will
likely be wrong, as the Collector likely doesn't know whether there are multiple containers within that pod.
likely be wrong, as the Collector might not know from which container within that pod the telemetry originated.
However, Collectors can set the `service.instance.id` if they can unambiguously determine the service instance
for that telemetry. This is typically the case for scraping receivers, as they know the target address and
port.
Expand Down

0 comments on commit 6b8421c

Please sign in to comment.