Prefer namespaced attributes

open-telemetry · Aug 29, 2023 · 515e266 · 515e266
1 parent e607302
commit 515e266
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docs/database/elasticsearch.md b/docs/database/elasticsearch.md
@@ -39,8 +39,8 @@ in order to map the path part values to their names.
 <!-- semconv db.elasticsearch -->
 | Attribute  | Type | Description  | Examples  | Requirement Level |
 |---|---|---|---|---|
-| `db.elasticsearch.cluster_name` | string | Represents the identifier of an Elasticsearch cluster. [1] | `e9106fc68e3044f0b1475b04bf4ffd5f` | Recommended: [2] |
-| `db.elasticsearch.cluster_instance` | string | Represents the identifier of the node/instance to which the request was routed. [3] | `instance-0000000001` | Recommended: [4] |
+| `db.elasticsearch.cluster.name` | string | Represents the identifier of an Elasticsearch cluster. [1] | `e9106fc68e3044f0b1475b04bf4ffd5f` | Recommended: [2] |
+| `db.elasticsearch.cluster.instance` | string | Represents the identifier of the node/instance to which the request was routed. [3] | `instance-0000000001` | Recommended: [4] |
 | [`db.operation`](database-spans.md) | string | The endpoint identifier for the request. [5] | `search`; `ml.close_job`; `cat.aliases` | Required |
 | [`db.statement`](database-spans.md) | string | The request body for a [search-type query](https://www.elastic.co/guide/en/elasticsearch/reference/current/search.html), as a json string. | `"{\"query\":{\"term\":{\"user.id\":\"kimchy\"}}}"` | Recommended: [6] |
 | `http.request.method` | string | HTTP request method. [7] | `GET`; `POST`; `HEAD` | Required |

diff --git a/model/trace/database.yaml b/model/trace/database.yaml
@@ -454,7 +454,7 @@ groups:
         examples: [ '"{\"query\":{\"term\":{\"user.id\":\"kimchy\"}}}"' ]
       - ref: server.address
       - ref: server.port
-      - id: cluster_name
+      - id: cluster.name
         type: string
         requirement_level:
           recommended: >
@@ -465,7 +465,7 @@ groups:
         examples: ["e9106fc68e3044f0b1475b04bf4ffd5f"]
         note: >
           For Elastic Cloud hosted deployents the "X-Found-Handling-Cluster" HTTP response header contains the cluster ID.
-      - id: cluster_instance
+      - id: cluster.instance
         type: string
         requirement_level:
           recommended: >