Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorate deprecations with suggested replacements #69

Closed
gabrieljones opened this issue May 14, 2024 · 1 comment · Fixed by #89
Closed

Decorate deprecations with suggested replacements #69

gabrieljones opened this issue May 14, 2024 · 1 comment · Fixed by #89
Labels
good first issue Good for newcomers

Comments

@gabrieljones
Copy link

gabrieljones commented May 14, 2024 •
edited
Loading

Please decorate the deprecations with suggested replacements.
#62
@gabrieljones gabrieljones changed the title Add suggested replacements for deprecations in https://github.com/open-telemetry/semantic-conventions-java/pull/62 Decorate deprecations with suggested replacements May 14, 2024
@jack-berg jack-berg added the good first issue Good for newcomers label May 20, 2024
@peterdk
Copy link

peterdk commented Jun 21, 2024 •
edited
Loading

So yeah, I just started implementing OpenTelemetry, but was getting stuck, cause all the SemanticAttributes.* state that they are deprecated, but nowhere indicated what I should use. After some time I figured out that I need HttpAttributes.* for my usecase, but nowhere is this indicated, and also not that these classes exist.

Docs here use SemanticAttributes.*:
https://opentelemetry.io/docs/languages/java/instrumentation/#traces

cboudereau added a commit to cboudereau/semantic-conventions-java that referenced this issue Sep 17, 2024
@cboudereau
fix: add new class for deprecated (open-telemetry#69)
6ece1a4
@cboudereau cboudereau mentioned this issue Sep 17, 2024
Merged
jack-berg pushed a commit that referenced this issue Oct 9, 2024
@cboudereau @trask
fix(#69): add new class annotations to deprecated classes (#89)
e1254cf 
* fix: add new class for deprecated (#69)

* clean

* use @see instead of @link for classes migrated to another jar

* fix

* format

* remove stable

* rename cloud attributes in comments

* remove deprecated duplicates

* rename moved class from #83

* format

* Update semconv/src/main/java/io/opentelemetry/semconv/ResourceAttributes.java

Co-authored-by: Trask Stalnaker <[email protected]>

---------

Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#69): add new class annotations to deprecated classes cboudereau/semantic-conventions-java
3 participants
@peterdk @gabrieljones @jack-berg