This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Explain the Metric API instruments #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2020
Closed
MrAlias
reviewed
Apr 21, 2020
jmacd
changed the title
added 2 commits
April 23, 2020 01:55
bogdandrutu
approved these changes
Apr 23, 2020
bogdandrutu
reviewed
Apr 23, 2020
jmacd
requested review from
arminru,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
|
Thanks @MikeGoldsmith @codeboten. I found other |
bogdandrutu
reviewed
Apr 28, 2020
MrAlias
approved these changes
Apr 28, 2020
|
There is an outstanding discussion here, #98 (comment), but it's not about the matter at hand. If we agree about the names of the instruments and their default aggregation, then I think this PR is ready to merge. The debate above is about how we document the protocol and the internals of the SDK and export pipeline. I do not think the outcome of this debate will have an impact on the specification we write for the API. In any case we shouldn't hold this up over a decision about use of "Temporal quality" in the API documentation. |
cijothomas
approved these changes
Apr 29, 2020
lzchen
approved these changes
Apr 29, 2020
|
@open-telemetry/specs-approvers this OTEP got very popular, can we review this to make progress? |
tigrannajaryan
approved these changes
May 2, 2020
|
@open-telemetry/specs-approvers please approve this. We have reached agreement by all, and the only outstanding discussion point belongs to the SDK: open-telemetry/opentelemetry-proto#147 |
added 2 commits
May 4, 2020 16:39
|
Please fix markdown lint errors :) |
carlosalberto
approved these changes
May 5, 2020
added 2 commits
May 5, 2020 09:20
|
@bogdandrutu Done. Needs one more approver 😆 |
yurishkuro
approved these changes
May 6, 2020
|
@bogdandrutu Let's merge this. |
|
Yes Sir :) |
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* Nine instruments * WIP: More explanation, starting on details section * Introduction * Typo fix * Table fmt * Rewrite without async delta instruments * More examples * Draft is ready * More names considered * More examples from review feedback * From comments * Typos * Address question about MMSC * About ValueObserver temporal quality * More on temporal quality terminology * 88 links to otep 88 * Swap temporal quality and default aggregation columns * Move link ref * Add 'Input' to the temporal quality header * Add detail * Rename into ./metrics * Lint * Lint
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* Nine instruments * WIP: More explanation, starting on details section * Introduction * Typo fix * Table fmt * Rewrite without async delta instruments * More examples * Draft is ready * More names considered * More examples from review feedback * From comments * Typos * Address question about MMSC * About ValueObserver temporal quality * More on temporal quality terminology * 88 links to otep 88 * Swap temporal quality and default aggregation columns * Move link ref * Add 'Input' to the temporal quality header * Add detail * Rename into ./metrics * Lint * Lint
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
* Nine instruments * WIP: More explanation, starting on details section * Introduction * Typo fix * Table fmt * Rewrite without async delta instruments * More examples * Draft is ready * More names considered * More examples from review feedback * From comments * Typos * Address question about MMSC * About ValueObserver temporal quality * More on temporal quality terminology * 88 links to otep 88 * Swap temporal quality and default aggregation columns * Move link ref * Add 'Input' to the temporal quality header * Add detail * Rename into ./metrics * Lint * Lint
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
* Nine instruments * WIP: More explanation, starting on details section * Introduction * Typo fix * Table fmt * Rewrite without async delta instruments * More examples * Draft is ready * More names considered * More examples from review feedback * From comments * Typos * Address question about MMSC * About ValueObserver temporal quality * More on temporal quality terminology * 88 links to otep 88 * Swap temporal quality and default aggregation columns * Move link ref * Add 'Input' to the temporal quality header * Add detail * Rename into ./metrics * Lint * Lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document replaces OTEPs #93 and #96.
The number of instruments is expanded to 6.
Resolves open-telemetry/opentelemetry-specification#467
Resolves open-telemetry/opentelemetry-specification#465
Resolves open-telemetry/opentelemetry-specification#462