This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
zPages proposal #110
Merged
zPages proposal #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKanzhelev
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
yurishkuro
reviewed
Jun 2, 2020
reyang
reviewed
Jun 6, 2020
reyang
reviewed
Jun 6, 2020
bogdandrutu
approved these changes
Jun 6, 2020
yurishkuro
approved these changes
Jun 6, 2020
jmacd
approved these changes
Jun 8, 2020
arminru
reviewed
Jun 8, 2020
|
|
||
| This is a request for a general direction approval. There are a few principles for the development: | ||
|
|
||
| 1. zPages MUST NOT be hardcoded into OpenTelemetry SDK. |
There was a problem hiding this comment.
What do you mean by "not be hardcoded"? Something like this?
Suggested change
| 1. zPages MUST NOT be hardcoded into OpenTelemetry SDK. | |
| 1. zPages MUST NOT be enabled or configured by default in the OpenTelemetry SDK. |
There was a problem hiding this comment.
Or does this mean it must be supplied in a separate package/code unit rather than "weaved into" the SDK?
There was a problem hiding this comment.
@SergeyKanzhelev Please clarify.
There was a problem hiding this comment.
I agree with your interpretation about making zPages a separate package / code unit, at the level of a span processor (for tracing). In OpenCensus, the zPages support was baked-in to the default SDK tracer. This relates to open-telemetry/opentelemetry-specification#373 about having access to live, unfinished spans.
| This is a request for a general direction approval. There are a few principles for the development: | ||
|
|
||
| 1. zPages MUST NOT be hardcoded into OpenTelemetry SDK. | ||
| 2. OpenTelemetry implementation of zPages MUST be split as two separate components - one for data, another for rendering. So that, for example, data providers could be also integrated into other rendering frameworks. |
There was a problem hiding this comment.
Suggested change
| 2. OpenTelemetry implementation of zPages MUST be split as two separate components - one for data, another for rendering. So that, for example, data providers could be also integrated into other rendering frameworks. | |
| 2. OpenTelemetry implementation of zPages MUST be split into two separate components - one for data collection and handling, another for rendering. This way, for example, data providers could be also integrated into other rendering frameworks. |
My impression is that it's not. @SergeyKanzhelev could you clarify this one? (maybe also mention this in the experimental folder PR). |
|
@carlosalberto @jmacd no, it's not on the path for 1.0. |
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* zPages proposal * renamed file to the PR number * linter issues * linter issues * added some principles for zPages development * fixes after Reiley review
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
* zPages proposal * renamed file to the PR number * linter issues * linter issues * added some principles for zPages development * fixes after Reiley review
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
* zPages proposal * renamed file to the PR number * linter issues * linter issues * added some principles for zPages development * fixes after Reiley review
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
* zPages proposal * renamed file to the PR number * linter issues * linter issues * added some principles for zPages development * fixes after Reiley review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.