This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 164
Log Data Model: Rename ShortName to Name #109
Merged
carlosalberto
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/renameshortname
Jun 4, 2020
Merged
Log Data Model: Rename ShortName to Name #109
carlosalberto
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/renameshortname
Jun 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to open-telemetry/opentelemetry-specification#622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
tigrannajaryan
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
May 28, 2020 19:50
MikeGoldsmith
approved these changes
May 28, 2020
reyang
approved these changes
May 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see that Name
is shorter than ShortName
🧙♀️
arminru
approved these changes
May 29, 2020
rahulchheda
approved these changes
May 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, might want to take this in.
Else /lgtm
zenmoto
approved these changes
Jun 2, 2020
bogdandrutu
approved these changes
Jun 3, 2020
carlosalberto
approved these changes
Jun 3, 2020
Thanks for the approvals. Maintainers: please merge the PR. |
Thanks @carlosalberto ! |
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
Contributes to open-telemetry/opentelemetry-specification#622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
Contributes to open-telemetry/opentelemetry-specification#622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
Contributes to open-telemetry/opentelemetry-specification#622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
Contributes to #622 This aligns the naming to what is already used for Embedded Logs (Span.Event). There is no change of semantics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to open-telemetry/opentelemetry-specification#622
This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.