Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Log Data Model: Rename ShortName to Name #109

Conversation

tigrannajaryan
Copy link
Member

Contributes to open-telemetry/opentelemetry-specification#622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.

Contributes to open-telemetry/opentelemetry-specification#622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that Name is shorter than ShortName 🧙‍♀️

Copy link

@rahulchheda rahulchheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, might want to take this in.
Else /lgtm

text/0097-log-data-model.md Show resolved Hide resolved
@tigrannajaryan
Copy link
Member Author

Thanks for the approvals.

Maintainers: please merge the PR.

@carlosalberto carlosalberto merged commit c14bf4c into open-telemetry:master Jun 4, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/renameshortname branch June 4, 2020 16:59
@tigrannajaryan
Copy link
Member Author

Thanks @carlosalberto !

carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
Contributes to open-telemetry/opentelemetry-specification#622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 23, 2024
Contributes to open-telemetry/opentelemetry-specification#622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.
carlosalberto pushed a commit to carlosalberto/oteps that referenced this pull request Oct 30, 2024
Contributes to open-telemetry/opentelemetry-specification#622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.
carlosalberto pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Nov 8, 2024
Contributes to #622

This aligns the naming to what is already used for Embedded Logs (Span.Event).
There is no change of semantics.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants