(concurrentbatchprocessor): add in-flight byte limit to producer queue #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moh-osman3
force-pushed
the
mohosman/batchprocessor-inflight-limit
branch
from
e367aca to
677c45f
Compare
jmacd
reviewed
Nov 15, 2023
collector/processor/concurrentbatchprocessor/batch_processor.go
Outdated
Show resolved
Hide resolved
jmacd
changed the title
jmacd
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option in the
concurrentbatchprocessornamedmax_in_flight_bytes. This config option will be used by processor to control admission (using a semaphore) into the producer queue based on the size of requests.Fixes #80.
Fixes #11.