Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Update from open-telemetry/opentelemetry-collector #585

Closed
wants to merge 1 commit into from
Closed

Docs Update from open-telemetry/opentelemetry-collector #585

wants to merge 1 commit into from

Conversation

austinlparker
Copy link
Member

This is an automated pull request.

@austinlparker austinlparker requested a review from a team May 19, 2021 15:15
@austinlparker
Copy link
Member Author

There was some drift that needs to be synced back to the collector repo before this gets merged

@austinlparker
Copy link
Member Author

These changes have been synced in open-telemetry/opentelemetry-collector#3267, this PR can be merged or we can wait for another push.

@austinlparker austinlparker mentioned this pull request May 24, 2021
Closed
mxiamxia
mxiamxia reviewed May 24, 2021
View reviewed changes
content/en/docs/collector/getting-started.md
@@ -75,7 +75,7 @@ $ git clone [email protected]:open-telemetry/opentelemetry-collector.git; \
cd opentelemetry-collector/examples; \
go build main.go; ./main & pid1="$!";
docker run --rm -p 13133:13133 -p 14250:14250 -p 14268:14268 \
-p 55678-55680:55678-55680 -p 8888:8888 -p 9411:9411 \
-p 55678-55679:55678-55679 -p 4317:4317 -p 8888:8888 -p 9411:9411 \
-v "${PWD}/otel-local-config.yaml":/otel-local-config.yaml \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-v "${PWD}/otel-local-config.yaml":/otel-local-config.yaml \
-v "${PWD}/local/otel-config.yaml":/otel-local-config.yaml \

@austinlparker
Copy link
Member Author

@mxiamxia if you'd like to make changes to this, you need to make a PR against the authoritative copy in the collector repo (https://github.com/open-telemetry/opentelemetry-collector/tree/main/website_docs) so they don't drift out of sync

@mxiamxia
Copy link
Member

@mxiamxia if you'd like to make changes to this, you need to make a PR against the authoritative copy in the collector repo (https://github.com/open-telemetry/opentelemetry-collector/tree/main/website_docs) so they don't drift out of sync

OK. l'll send a separate PR to correct the docker starting command. Fine with merging this PR.

mxiamxia
mxiamxia approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flands flands closed this Jun 22, 2021
@chalin chalin deleted the docs-open-telemetry/opentelemetry-collector-437ae6f6e300b628cd6b578efa6500b2efa614eb branch August 17, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

@flands flands Awaiting requested review from flands

@jparsana jparsana Awaiting requested review from jparsana

@mtwo mtwo Awaiting requested review from mtwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austinlparker @mxiamxia @flands