Fix: fix dice number generator in JS examples #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar60310
force-pushed
the
fix/fix-js-dice-generator
branch
from
3d2c550 to
7b306d8
Compare
trentm
approved these changes
Nov 8, 2024
theletterf
approved these changes
Nov 10, 2024
drewby
pushed a commit
to drewby/opentelemetry.io
that referenced
this pull request
Nov 21, 2024
ymotongpoo
pushed a commit
to ymotongpoo/opentelemetry.io
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not a major issue, but it seems that the dice in our example code only rolls
1,2,3,4, and5. Fixing this could make the game fairer. 🤣