Add jdbi to native java instrumentation registry #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Nov 2, 2024
svrnm
added a commit
to svrnm/opentelemetry.io
that referenced
this pull request
Nov 4, 2024
follow up for open-telemetry#5512: based on the documentation (https://jdbi.org/#_opentelemetry_tracing) the otel integration requires a plugin and is not a native integration: > The OpenTelemetry project provides a SDK to implement distributed tracing. Installing the JdbiOpenTelemetryPlugin from the jdbi3-opentelemetry artifact will cause Jdbi statements to emit trace spans recording data similarly as JFR events above. Additionally, it will add the trace id to JFR events. cc @jaydeluca
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of release 3.46.0, JDBI added native OTel instrumentation.
This PR adds jdbi to the registry so that it will be listed on the Instrumentation ecosystem page under Native Instrumentation