Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document enabling trace self-telemetry #5449

Merged

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Oct 21, 2024

The Collector > Internal telemetry page mentions that "Tracing instrumentation is still under active development", but not how to enable it. This PR adds an explanation for that, based on this document in the collector repo docs. Some outdated advice was removed, and warnings about the experimental status of the feature and about potential self-telemetry loops were added.

Fixes #5446.

@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team October 21, 2024 15:42
@opentelemetrybot opentelemetrybot requested a review from a team October 21, 2024 15:56
@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review October 21, 2024 16:02
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner October 21, 2024 16:02
@mx-psi mx-psi requested a review from codeboten October 22, 2024 07:50
@opentelemetrybot opentelemetrybot requested a review from a team October 22, 2024 08:40
@jade-guiton-dd
Copy link
Contributor Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@mx-psi
Copy link
Member

mx-psi commented Oct 23, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@opentelemetrybot opentelemetrybot requested a review from a team October 23, 2024 16:03
@opentelemetrybot opentelemetrybot requested a review from a team October 25, 2024 15:29
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few small copy edits. Thanks!

content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
content/en/docs/collector/internal-telemetry.md Outdated Show resolved Hide resolved
@jade-guiton-dd
Copy link
Contributor Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@tiffany76
Copy link
Contributor

@codeboten, any last thoughts or is this good to go?

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge for now, this is a good enhancement

@cartermp cartermp added this pull request to the merge queue Nov 2, 2024
Merged via the queue into open-telemetry:main with commit 3a508b4 Nov 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[docs/collector/internal-telemetry] Document how to enable traces on the Collector
6 participants