Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update links for new ocb binaries #5041

Merged
merged 3 commits into from
Aug 14, 2024
Merged

update links for new ocb binaries #5041

merged 3 commits into from
Aug 14, 2024

Conversation

jackgopack4
Copy link
Contributor

closes #5031

@jackgopack4 jackgopack4 requested a review from a team August 14, 2024 13:37
@opentelemetrybot opentelemetrybot requested review from a team and removed request for a team August 14, 2024 13:37
songy23
songy23 reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-telemetry/opentelemetry.io/actions/runs/10388690003/job/28765082750?pr=5041

ERROR: the files above have changed. Locally rerun npm run test-and-fix and commit changes

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

/fix:all

@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

Not sure if I have permissions but worth trying 😄

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10389092953

mx-psi
mx-psi approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jack!

@theletterf
Copy link
Member

@jackgopack4 Try running npm install and npm run fix:all from your CLI. That should remove the submodule changes.

@opentelemetrybot opentelemetrybot requested review from a team and codeboten and removed request for a team August 14, 2024 16:34
@svrnm
fix git submodule
5074c86 
Signed-off-by: svrnm <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team August 14, 2024 16:38
@svrnm svrnm added this pull request to the merge queue Aug 14, 2024
Merged via the queue into open-telemetry:main with commit 7e551bc Aug 14, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 left review comments

@mx-psi mx-psi mx-psi approved these changes

@theletterf theletterf theletterf approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
sig:collector
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building a custom collector
6 participants
@jackgopack4 @mx-psi @opentelemetrybot @theletterf @songy23 @svrnm