Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][i18n] Spell check content/pt, and enable other dicts #4982

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 6, 2024

@chalin chalin added CI/infra CI & infrastructure i18n internationalization lang:pt labels Aug 6, 2024
@chalin chalin requested a review from a team August 6, 2024 23:18
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would I need to open a similar PR for es?

@chalin chalin force-pushed the chalin-im-spell-check-pt-etc-2024-08-06 branch from 981cf5b to b72e0a9 Compare August 7, 2024 09:33
@chalin
Copy link
Contributor Author

chalin commented Aug 7, 2024

Would I need to open a similar PR for es?

All we'd need to do is add an es dictionary (as an NPM package, and then to the cSpell config). Generally speaking, I'd suggest that we do that as part of the "on boarding" of the new language — that is, with their first PR that contains the translation of the homepage. WDYT?

@chalin chalin added this pull request to the merge queue Aug 7, 2024
Merged via the queue into open-telemetry:main with commit 65fd0c2 Aug 7, 2024
17 checks passed
@chalin chalin deleted the chalin-im-spell-check-pt-etc-2024-08-06 branch August 7, 2024 11:17
svrnm pushed a commit to svrnm/opentelemetry.io that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization lang:pt
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants