-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major rework of ecosystem pages #3060
Conversation
Hmmm, I guess now that I lay it out it's not that much worse. Eh, let's deal with that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the changes overall.
Would also like @chalin to pipe in here, but otherwise I think this one's good. |
Taking a look now (just back). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, very nice improvements; thanks @svrnm! 🎉
I focused on copyedits for the prose in this round of reviews. See inline comments.
(Later I might have some suggested improvements and simplifications to offer for the shortcodes, but they could land as is for now too.)
thanks @chalin , I applied all the suggestions you made |
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there! I made another pass of copyediting. PTAL
Co-authored-by: Patrice Chalin <[email protected]>
thanks once again, all suggestions have been applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @svrnm.
Maybe try the /fix:*
commands (for fix:format
and fix:refcache
) to see if they work?
/fix:* |
Sorry if I wasn't clear: I meant to try each command separately. We don't have |
All green, merging! |
🎉 |
This PR addresses some of the things we discussed in #2178, #2238, #1701
Note, that I made a lot of decisions along the way, so don't hesitate to call out anything you dislike on how I have changed things.
Here are a few pointers:
Preview: