Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new blog post for OTel Q&A - May #2812

Merged
merged 28 commits into from
Jun 7, 2023
Merged

Add new blog post for OTel Q&A - May #2812

merged 28 commits into from
Jun 7, 2023

Conversation

avillela
Copy link
Contributor

@avillela avillela commented Jun 1, 2023 •
edited by chalin
Loading

@avillela avillela requested review from a team June 1, 2023 19:31
chalin
chalin requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the following external links by (local) paths:

  • https://opentelemetry.io/docs/... by /docs/...
  • https://opentelemetry.io/community/... by /community/...

@avillela
Copy link
Contributor Author

avillela commented Jun 2, 2023

Replace the following external links by (local) paths:

  • https://opentelemetry.io/docs/... by /docs/...
  • https://opentelemetry.io/community/... by /community/...

Done @chalin. I thought there used to be a linter that would catch this? I don't recall it erring out this time.

@avillela avillela requested a review from chalin June 2, 2023 14:00
@chalin
Copy link
Contributor

chalin commented Jun 2, 2023 •
edited
Loading

Done @chalin.

👍

I thought there used to be a linter that would catch this? I don't recall it erring out this time.

We decided to turn that check into a warning. To see those warnings you (currently) have to look at the build log, e.g.: https://github.com/open-telemetry/opentelemetry.io/actions/runs/5149237070/jobs/9271985379:

Start building sites … 
hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended linux/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=gohugoio
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/community/end-user/interviews-feedback/
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/concepts/signals/traces/
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/concepts/signals/metrics/
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/concepts/signals/
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/collector/
WARN 2023/06/01 21:07:[44](https://github.com/open-telemetry/opentelemetry.io/actions/runs/5149237070/jobs/9271985379#step:4:45) blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/migration/opentracing/
WARN 2023/06/01 21:07:44 blog/2023/end-user-q-and-a-03.md: use a local path, not an external URL, for the following reference to a site local page: https://opentelemetry.io/docs/k8s-operator/#introduction
...

I'll see if I can surface those to make it easier:

@chalin chalin mentioned this pull request Jun 2, 2023
Closed
1 task
chalin
chalin reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! See inline for suggested edits.

content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
@avillela avillela requested a review from chalin June 2, 2023 16:46
cartermp
cartermp approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great interview, this is fantastic stuff.

content/en/blog/2023/end-user-q-and-a-03.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the avillela-blog-post-otel-q-and-a-03 branch from 97326a5 to ec94ea7 Compare June 2, 2023 19:05
@chalin
Copy link
Contributor

chalin commented Jun 2, 2023

Hi @avillela - there are three remaining / pending of my comments. Just wondering if you were planning on addressing those too?

@avillela
Copy link
Contributor Author

avillela commented Jun 2, 2023

Hi @avillela - there are three remaining / pending of my comments. Just wondering if you were planning on addressing those too?

@chalin my bad! They got buried in the middle there! I've taken care of them as well. 😄

@avillela avillela requested a review from cartermp June 2, 2023 19:57
chalin
chalin approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

svrnm
svrnm approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome :-)

@chalin chalin force-pushed the avillela-blog-post-otel-q-and-a-03 branch from 6f74e78 to ae596b6 Compare June 6, 2023 15:45
@avillela
Copy link
Contributor Author

avillela commented Jun 7, 2023

@chalin that latest force-push seems to have broken the build. I pulled in your changes and ran rpm run tests and it came up with a bunch of errors. Are you able to look into it?

avillela and others added 16 commits June 7, 2023 13:56
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
352fa73 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
6e8b918 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
e57007f 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
32e19c7 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
0806b26 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
ce2cecf 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
94a146a 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
fddc613 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
8dc4af3 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Prettify
e72b625
@avillela @cartermp @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
71ea644 
Co-authored-by: Phillip Carter <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
255a923 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
f9a32fc 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Update content/en/blog/2023/end-user-q-and-a-03.md
183a96f 
Co-authored-by: Patrice Chalin <[email protected]>
@avillela @chalin
Prettify
1e10d39
@chalin
Use canonical path to Concept page that has moved
16d0b1e
@chalin
Copy link
Contributor

chalin commented Jun 7, 2023

@avillela - I've submitted a fix to the link, but until GH PRs are working again, we'll have to wait: https://www.githubstatus.com.

@chalin chalin force-pushed the avillela-blog-post-otel-q-and-a-03 branch from ae596b6 to 1e10d39 Compare June 7, 2023 18:20
@svrnm svrnm merged commit 43bacb6 into open-telemetry:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@svrnm svrnm svrnm approved these changes

@cartermp cartermp Awaiting requested review from cartermp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avillela @chalin @svrnm @cartermp