Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't format the Vendors table #2550

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 28, 2023

  • Temporary "fix" (until the Vendors table is data driven) to avoid rebase conflicts when entries are added to the vendor table via separate commits: don't run the formatter over the vendor table.
  • Trimmed https:// from the start of the link text (not the link URL) of the new ITRS entry.
  • Dropped the trailing | from the end of the table markdown to make it easier to add entry (and not worry about padding the last row cell with spaces.
  • Other than that the table entries are the same
  • Kinda contributes to Re-do vendors page & consider new adopters page #2178

@chalin chalin requested a review from a team March 28, 2023 23:26
@cartermp cartermp merged commit 8a7d2fb into open-telemetry:main Mar 29, 2023
@chalin chalin deleted the chalin-im-prettier-ignore-vendor-table-2023-03-28 branch March 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants