Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: exposing openTelemetry collector #1684

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Aug 30, 2022

This post extends the blog posts and shows how to establish secure communication between two collectors in different Kubernetes clusters.

Preview:
https://deploy-preview-1684--opentelemetry.netlify.app/blog/2022/k8s-otel-expose/


cc @kevinearls @pavolloffay @rubenvp8510

@frzifus
Copy link
Member Author

frzifus commented Aug 30, 2022

oh, makes sense.

10:53:22 AM: ERROR 2022/08/30 08:53:22 blog/2022/k8s-otel-expose.md: use a local path, not an external URL, for the following reference to a local page: https://opentelemetry.io/docs/collector/
10:53:22 AM: ERROR 2022/08/30 08:53:22 blog/2022/k8s-otel-expose.md: use a local path, not an external URL, for the following reference to a local page: https://opentelemetry.io/docs/collector/getting-started/#kubernetes
10:53:22 AM: ERROR 2022/08/30 08:53:22 blog/2022/k8s-otel-expose.md: use a local path, not an external URL, for the following reference to a local page: https://opentelemetry.io/blog/2022/k8s-metadata/

@frzifus frzifus changed the title blog: Exposing OpenTelemetry Collector blog: exposing openTelemetry collector Aug 30, 2022
Copy link
Member

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a partial review. I will continue later. Please let me know if you have any questions

content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the blog/expose_otel_collector branch from b46ac41 to 2a3691d Compare August 30, 2022 11:19
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
@frzifus frzifus force-pushed the blog/expose_otel_collector branch 5 times, most recently from a0e1b39 to 46059bc Compare September 1, 2022 16:03
Copy link
Member

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, a few very minor nitpicks.

content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the blog/expose_otel_collector branch 2 times, most recently from 38bf23c to dd1e451 Compare September 2, 2022 14:27
@svrnm
Copy link
Member

svrnm commented Sep 5, 2022

@frzifus can you please make sure that the netlify checks run through, you can click on "Details" to see why the checks failed.

@frzifus
Copy link
Member Author

frzifus commented Sep 5, 2022

@svrnm its caused by wrong relative paths. I tried a few things without success :(

4:28:20 PM: blog/2022/k8s-otel-expose/index.html
4:28:20 PM:   target does not exist --- blog/2022/k8s-otel-expose/index.html --> /docs/collector/_index.md
4:28:20 PM:   target does not exist --- blog/2022/k8s-otel-expose/index.html --> /docs/collector/getting-started.md
4:28:20 PM:   target does not exist --- blog/2022/k8s-otel-expose/index.html --> /blog/2022/k8s-metadata.md
4:28:20 PM:   target does not exist --- blog/2022/k8s-otel-expose/index.html --> /docs/collector/_index.md
4:28:20 PM: ========================================================================
4:28:20 PM: ✘✘✘ failed in 773.66838ms
4:28:20 PM: 4 errors in 624 documents
4:28:21 PM: make: *** [Makefile:19: check-links] Error 1

Could you point me to some documentation how the relative paths are organzied or give me a hint? :)

@frzifus frzifus force-pushed the blog/expose_otel_collector branch 4 times, most recently from c534611 to 9dff5fc Compare September 5, 2022 11:35
@frzifus frzifus marked this pull request as ready for review September 5, 2022 11:37
@frzifus frzifus requested review from a team, svrnm and pavolloffay and removed request for svrnm and pavolloffay September 5, 2022 11:37
@frzifus frzifus force-pushed the blog/expose_otel_collector branch from 9dff5fc to 2b19b97 Compare September 5, 2022 11:41
@svrnm
Copy link
Member

svrnm commented Sep 5, 2022

Could you point me to some documentation how the relative paths are organzied or give me a hint? :)

looks like you figured it out? I can see the preview now, which makes it also easier for me to provide some more review:

https://deploy-preview-1684--opentelemetry.netlify.app/blog/2022/k8s-otel-expose/

@frzifus
Copy link
Member Author

frzifus commented Sep 5, 2022

Awesome thank you @svrnm. I will have a look. :)

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, please review.

content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
Copy link
Member

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of incredibly nitpicky nits. Other than that LGTM.

content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
content/en/blog/2022/k8s-otel-expose.md Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the blog/expose_otel_collector branch 3 times, most recently from 1241822 to 4bdca32 Compare September 5, 2022 12:11
@frzifus frzifus force-pushed the blog/expose_otel_collector branch from 4bdca32 to 4f1d384 Compare September 5, 2022 12:24
@frzifus frzifus requested a review from svrnm September 5, 2022 12:25
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm svrnm added the blog label Sep 5, 2022
@svrnm
Copy link
Member

svrnm commented Sep 5, 2022

@open-telemetry/blog-approvers : please review, thanks!

Copy link
Member

@austinlparker austinlparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@svrnm
Copy link
Member

svrnm commented Sep 6, 2022

lgtm

@frzifus: we just merged another blog post (#1677), will give this a few days to stay on top and then we will have yours :-)

Thank you for writing this and thanks for everyone contributing feedback 🎉

@frzifus
Copy link
Member Author

frzifus commented Sep 6, 2022

perfect, Thanks for taking care :)

@svrnm
Copy link
Member

svrnm commented Sep 6, 2022

@frzifus: oh, one more thing, can you share your social handles (twitter, linkedin) with us, so if people share that blog post (when it's live) can tag you?

@frzifus
Copy link
Member Author

frzifus commented Sep 6, 2022

@svrnm does it matter that iam 99% inactive on that platforms? 👯
handles: LinkedIn, Twitter

@svrnm
Copy link
Member

svrnm commented Sep 6, 2022

@svrnm does it matter that iam 99% inactive on that platforms? 👯 handles: LinkedIn, Twitter

It matters for your health, great decision 😂 ... if you don't want to be tagged people can skip it, but otherwise I think it doesn't matter

@frzifus
Copy link
Member Author

frzifus commented Sep 6, 2022

hehe, yes. ah no its fine :)

@svrnm svrnm merged commit 753dba5 into open-telemetry:main Sep 8, 2022
@svrnm
Copy link
Member

svrnm commented Sep 8, 2022

And we are live! https://opentelemetry.io/blog/ thank you @frzifus

@frzifus frzifus deleted the blog/expose_otel_collector branch September 8, 2022 15:33
@frzifus
Copy link
Member Author

frzifus commented Sep 8, 2022

Awesome :)

@chalin
Copy link
Contributor

chalin commented Oct 8, 2022

Hi all, FYI the diagram source inclusion had an unintended consequence:

I'll drop the source in a subsequent PR since it can be recovered from this PR.

If you'd like to include a source file like that next time, where the file isn't indented to be processed by Hugo, prefix the file name with an underscore. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants