-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: exposing openTelemetry collector #1684
Conversation
oh, makes sense.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a partial review. I will continue later. Please let me know if you have any questions
b46ac41
to
2a3691d
Compare
a0e1b39
to
46059bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a few very minor nitpicks.
38bf23c
to
dd1e451
Compare
@frzifus can you please make sure that the netlify checks run through, you can click on "Details" to see why the checks failed. |
@svrnm its caused by wrong relative paths. I tried a few things without success :(
Could you point me to some documentation how the relative paths are organzied or give me a hint? :) |
c534611
to
9dff5fc
Compare
9dff5fc
to
2b19b97
Compare
looks like you figured it out? I can see the preview now, which makes it also easier for me to provide some more review: https://deploy-preview-1684--opentelemetry.netlify.app/blog/2022/k8s-otel-expose/ |
Awesome thank you @svrnm. I will have a look. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of incredibly nitpicky nits. Other than that LGTM.
1241822
to
4bdca32
Compare
Signed-off-by: Benedikt Bongartz <[email protected]>
4bdca32
to
4f1d384
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@open-telemetry/blog-approvers : please review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
perfect, Thanks for taking care :) |
@frzifus: oh, one more thing, can you share your social handles (twitter, linkedin) with us, so if people share that blog post (when it's live) can tag you? |
hehe, yes. ah no its fine :) |
And we are live! https://opentelemetry.io/blog/ thank you @frzifus |
Awesome :) |
Hi all, FYI the diagram source inclusion had an unintended consequence: I'll drop the source in a subsequent PR since it can be recovered from this PR. If you'd like to include a source file like that next time, where the file isn't indented to be processed by Hugo, prefix the file name with an underscore. Cheers! |
This post extends the blog posts and shows how to establish secure communication between two collectors in different Kubernetes clusters.
Preview:
https://deploy-preview-1684--opentelemetry.netlify.app/blog/2022/k8s-otel-expose/
cc @kevinearls @pavolloffay @rubenvp8510