JS Docs: Temporarily get rid of metrics content in node getting started #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1534--opentelemetry.netlify.app/docs/instrumentation/js/getting-started/nodejs/
This temporarily resolves #1400 (and I believe another issue where someone pointed this out).
The metrics API is still experimental and appears to be undergoing quite a bit of change. Given that there's still churn, I think we should pull the existing (now older, incompatible) docs until metrics stabilize. I moved what was written to a
.oldfile so we can re-use most of it and then update code samples to use up to date APIs.I also added a small "next steps" blurb since that's a common thing we do in other docs.