Simplify and make js manual doc more correct #1435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@open-telemetry/javascript-approvers it looks like you're not listed as code owners for these docs - would you like to be added? I intend on making more docs changes here soon and it'd be good to get your eyes/opinions. |
cartermp
added a commit
that referenced
this pull request
Jun 13, 2022
This was referenced Jun 13, 2022
austinlparker
pushed a commit
that referenced
this pull request
Jun 15, 2022
dyladan
reviewed
Jun 16, 2022
|
Superseded by #1445 - will pull feedback over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1435--opentelemetry.netlify.app/docs/instrumentation/js/instrumentation/
This change does a few things:
SimpleSpanProcessortoBatchSpanProcessor. Got some feedback that this code is more likely to be copied into a production app and people probably shouldn't be usingSimpleSpanProcessorfor that