-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to be able to publish schema files from specification repo #577
Need to be able to publish schema files from specification repo #577
Comments
@flands @mtwo @austinlparker I need your advice on this. Does website SIG do regular meetings? I can join to discuss if you prefer that. |
We have meetings every two weeks, so if you want to show up next week then we can chat about it there. From a technical side it's pretty straightforward though, we can create a static directory that serves to whatever path then use the same automation that's available to sync changes between the language repos into the website to sync that on a manual trigger or on a release of the spec. |
The meeting is on the public calendar, it's 'Communications SIG' on every other thursday |
@austinlparker Thanks for confirming this is possible. I will join the SIG meeting next week and in the meantime I will try to put together a draft PR that does what you described. |
@austinlparker can you point me to the current automation that syncs the changes? |
Sure thing, here's an example in the Java repo: https://github.com/open-telemetry/opentelemetry-java/blob/main/.github/workflows/docs-update.yml Essentially you just need a source directory (on the spec side) and a target directory (on the website side), then the script will rsync one way from the source to the target on command/trigger. It would be nice if we could get a bot user for these actions that had permissions across repos so we wouldn't have to use my PAT, but we're using my PAT for now. |
@austinlparker so, just to clarify:
Does this sound right? |
Yeah, that all sounds right. There might be an extra piece of config on this side to expose |
Just as an FYI Tigran I'm moving house this week so my access will be limited from tomorrow until next Monday, in case we're trying to time this with something else. I'll try to keep an eye on things though. |
@austinlparker thanks, no rush. We need to publish the first file for 1.4.0 spec release which is still 3 weeks away, so we have plenty of time. And for the very first release we can even do it completely manually, so it shouldn't be a problem. |
As described in open-telemetry#577 this adds the first schema file. This should publish the file at ttps://opentelemetry.io/schemas/1.4.0 Merge this PR after specification 1.4.0 is released. We will automate the addition of future schemas later.
As described in open-telemetry#577 this adds the first schema file. This should publish the file at https://opentelemetry.io/schemas/1.4.0 Merge this PR after specification 1.4.0 is released. We will automate the addition of future schemas later.
As described in #577 this adds the first schema file. This should publish the file at https://opentelemetry.io/schemas/1.4.0 Merge this PR after specification 1.4.0 is released. We will automate the addition of future schemas later.
The action should be triggered manually after every spec release and will copy/update schema files from this repository to the website repository so that they become available publicly. The publish-schemas action after manual triggering will create a PR in https://github.com/open-telemetry/opentelemetry.io repo, and the PR needs to be approved and merged manually. This is similar to how we publish doc updates from language repos to the website repo. Resolves open-telemetry/opentelemetry.io#577 Resolves open-telemetry#1693
The action should be triggered manually after every spec release and will copy/update schema files from this repository to the website repository so that they become available publicly. The publish-schemas action after manual triggering will create a PR in https://github.com/open-telemetry/opentelemetry.io repo, and the PR needs to be approved and merged manually. This is similar to how we publish doc updates from language repos to the website repo. Resolves open-telemetry/opentelemetry.io#577 Resolves open-telemetry#1693
The action should be triggered manually after every spec release and will copy/update schema files from this repository to the website repository so that they become available publicly. The publish-schemas action after manual triggering will create a PR in https://github.com/open-telemetry/opentelemetry.io repo, and the PR needs to be approved and merged manually. This is similar to how we publish doc updates from language repos to the website repo. Resolves open-telemetry/opentelemetry.io#577 Resolves open-telemetry#1693
* Add automated Schema File publish action The action should be triggered manually after every spec release and will copy/update schema files from this repository to the website repository so that they become available publicly. The publish-schemas action after manual triggering will create a PR in https://github.com/open-telemetry/opentelemetry.io repo, and the PR needs to be approved and merged manually. This is similar to how we publish doc updates from language repos to the website repo. Resolves open-telemetry/opentelemetry.io#577 Resolves #1693 * Make branch name and commit message more relevant Co-authored-by: Sergey Kanzhelev <[email protected]>
* Add automated Schema File publish action The action should be triggered manually after every spec release and will copy/update schema files from this repository to the website repository so that they become available publicly. The publish-schemas action after manual triggering will create a PR in https://github.com/open-telemetry/opentelemetry.io repo, and the PR needs to be approved and merged manually. This is similar to how we publish doc updates from language repos to the website repo. Resolves open-telemetry/opentelemetry.io#577 Resolves open-telemetry/opentelemetry-specification#1693 * Make branch name and commit message more relevant Co-authored-by: Sergey Kanzhelev <[email protected]>
OTEP 0152 introduces the notion of schema files that need to be published at some canonical location for OpenTelemetry schemas. The OTEP proposes to use https://opentelemetry.io/schemas/ as the location for OpenTelemetry schema files.
The schema files are plain YAML file that should be published as is. The source of truth, the original content of the schema files will be in the specification repo, so that it is precisely tied with the version of the specification.
We will need to publish one schema file per each version of the specification.
I am looking for a solution to do that publishing here, in this repository, so that the schema files become available at https://opentelemetry.io/schemas/ and I need maintainer's advice on how they think we can achieve it.
Ideally it should be fully automated, so that whenever a new specification release is made the schema file is automatically published at https://opentelemetry.io/schemas/, however I think we can also settle for a semi-automated approach, since the publishing needs to happen monthly and provided that it is easy to do, it is not going to require much efforts or maintenance.
Once the schema files are published they never change, they are immutable.
The text was updated successfully, but these errors were encountered: