Add Locks to SwiftMetricsShim #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change access control on metricName setters to private to minimise leakage outside of the class.
Sherlouk
requested review from
nachoBonafonte and
SergeyKanzhelev
as code owners
nachoBonafonte
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
LGTM, I will give some time for @ktoso to review before merging
ktoso
approved these changes
Apr 7, 2021
|
Thanks for the ping! More than happy to review 👍 |
|
Thanks for taking a look Konrad 🙂 |
|
Looking good, now with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change access control on
metricNamesetters to private to minimise leakage outside of the class.Hopefully addresses the concerns of @ktoso in their code review on #155.