Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow samplers to modify tracestate #988

Merged
merged 6 commits into from
Sep 25, 2020
Merged

Allow samplers to modify tracestate #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43bb201
Allow samplers to modify tracestate, fix #856
Sep 22, 2020
d4b80a6
changelog
Sep 22, 2020
d050af3
review: tracestate is associated with Span through the context
Sep 22, 2020
8e5bab6
Update sdk.md
Sep 24, 2020
e73146e
Merge branch 'master' into tracestateSampler
Sep 24, 2020
652a1c2
Update sdk.md
Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ New:
* `exception.escaped` semantic span event attribute was added
([#784](https://github.com/open-telemetry/opentelemetry-specification/pull/784),
[#946](https://github.com/open-telemetry/opentelemetry-specification/pull/946))
- Allow samplers to modify tracestate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Allow samplers to modify tracestate
- Add (modified) Tracestate to the return value of Samplers

Otherwise it sounds like something optional but this actually changed the interface and SIGs will have to implement this.

([#856](https://github.com/open-telemetry/opentelemetry-specification/pull/988/))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
([#856](https://github.com/open-telemetry/opentelemetry-specification/pull/988/))
([#988](https://github.com/open-telemetry/opentelemetry-specification/pull/988/))

- Update the header name for otel baggage, and version date
([#981](https://github.com/open-telemetry/opentelemetry-specification/pull/981))

Expand Down
5 changes: 5 additions & 0 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ It produces an output called `SamplingResult` which contains:
* `RECORD_AND_SAMPLE` - `IsRecording() == true` AND `Sampled` flag` MUST be set.
* A set of span Attributes that will also be added to the `Span`. The returned
object must be immutable (multiple calls may return different immutable objects).
* A `Tracestate` that will be associated with the `Span` through the new
`SpanContext`.
Note: If the sampler returns an empty `Tracestate` here, the `Tracestate` will be cleared,
so samplers should normally return the passed-in `Tracestate` if they do not intend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
so samplers should normally return the passed-in `Tracestate` if they do not intend
so samplers SHOULD return the `Tracestate` passed to them, if they do not intend

Copy link
Member

@Oberon00 Oberon00 Sep 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a Note, we should not have upper-case requirements. If you want reword it, also drop the "Note:", and probably make it a MUST

to change it.

#### GetDescription

Expand Down