Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add semantic conventions for outgoing FaaS invocations #862
Add semantic conventions for outgoing FaaS invocations #862
Changes from 3 commits
1ea980a
f93d2f7
4cfd5dd
ea25a54
d9426a9
5eb629b
79ff97e
580e6c6
a3a34bc
a01c8c4
319f3e7
7930908
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inviting y'all to a naming/namespacing discussion! 😀
Please vote:
🎉 -
faas.invoked_name
,faas.invoked_provider
,faas.invoked_region
🚀 -
faas.invoked.name
,faas.invoked.provider
,faas.invoked.region
(introducing a separateinvoked
namespace)👀 - the above, but with
outgoing
instead ofinvoked
😕 - something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with all of them. 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think invoked is fine. I would weakly prefer a namespace probably, but I have no real reason other than "feels right".