Add OpenTelemetry API package layout #86
Conversation
mayurkale22
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
| ├── trace | ||
| │ ├── propagation # headers that are the public API for trace propagation, using different encodings. | ||
| │ └── samplers # is used to make decisions on `Span` sampling. | ||
| ├── distributedcontext |
There was a problem hiding this comment.
Does distributedcontext intend to cover local context (in-process propagation) as well?
If yes, suggest to consider context.
There was a problem hiding this comment.
looks like a hot topic for the Tuesday specification group call =)
There was a problem hiding this comment.
Based on the current Java reference implementation context (in-process) is a separate package, probably we should keep it that way as we discussed (currently we document the way java reference implementation did then later change if we agree otherwise).
There was a problem hiding this comment.
missed this. @mayurkale22 can you please fix?
| @@ -0,0 +1,56 @@ | |||
| # OpenTelemetry Project Package Layout | |||
There was a problem hiding this comment.
@mayurkale22 great document!
specification/package-layout.md
Outdated
| ### `/internal` (_Optional_) | ||
| Private application and library code. | ||
|
|
||
| ### `/log` (_In the future_) |
There was a problem hiding this comment.
| ### `/log` (_In the future_) | |
| ### `/logs` (_In the future_) |
I think it will be plural. Like metrics and resources
There was a problem hiding this comment.
I think log (singular) is a convention as package name? /cc @reyang
mayurkale22
force-pushed
the
package_structure
branch
from
d36823c to
84c835b
Compare
* Add basic package layout * Fix review comments * Add context package
…etry#86) * Explicitly forbid granting any permissions to individuals According to GDI security guidelines. * Update specification/repository.md Co-authored-by: Robert Pająk <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
* Add basic package layout * Fix review comments * Add context package
Fixes #52
The best way to view this is: https://github.com/open-telemetry/opentelemetry-specification/blob/84c835b1746d14fa18d087d789728bb5e071afad/specification/package-layout.md