Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up glossary and overview (resolves #528). #804

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Clean up glossary and overview (resolves #528). #804

merged 3 commits into from
Aug 14, 2020

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Aug 14, 2020 •
edited
Loading

Fixes #528.

Changes

  • Add link from overview to glossary and vice versa
  • Add TOC to overview and glossary (overview has it folded in <details>, glossary has it expanded as no one is gonna read it top to bottom).

@Oberon00 Oberon00 added release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:miscellaneous For issues that don't match any other spec label area:miscellaneous For issues that don't match any other area label priority:p2 Medium priority level labels Aug 14, 2020
@Oberon00 Oberon00 requested review from a team and yurishkuro August 14, 2020 11:29
@Oberon00 Oberon00 mentioned this pull request Aug 14, 2020
Open
Oberon00
Oberon00 commented Aug 14, 2020
View reviewed changes
specification/overview.md
@@ -290,10 +328,6 @@ name itself. Examples include:
* opentelemetry-instrumentation-flask (Python)
* @opentelemetry/instrumentation-grpc (Javascript)

## Code injecting adapters
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this TODO to a new issue #805.

@Oberon00 Oberon00 mentioned this pull request Aug 14, 2020
Closed
@carlosalberto carlosalberto self-requested a review August 14, 2020 14:47
@yurishkuro
Copy link
Member

No actual spec changes, so merging.

@yurishkuro yurishkuro merged commit b10bce8 into open-telemetry:master Aug 14, 2020
@Oberon00 Oberon00 deleted the feature/glossary-overview branch December 18, 2020 10:59
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@Oberon00
Clean up glossary and overview (resolves open-telemetry#528). (open-t…
2d5d401 
…elemetry#804)

* Clean up glossary and overview (resolves open-telemetry#528).

* Overview -> overview document.

* Remove TOC entry for Code Injecting adapters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@iNikem iNikem iNikem approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:miscellaneous For issues that don't match any other area label priority:p2 Medium priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redundancy between glossary and "vocabulary" in overview
5 participants
@Oberon00 @yurishkuro @carlosalberto @bogdandrutu @iNikem