Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralize attributes definition #722
Centralize attributes definition #722
Changes from 1 commit
518a89c
fc5fa3d
59c46aa
8961f99
0512762
0728aed
1cbb222
b520967
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the required here a MUST overriding the previous MAY? I'm not sure how to interpret this sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a note that explains the rationale for both of the above together. It is meant to ban SDKs and exporters from just dropping the null values from the array (changing the index of following elements).
Is what basically applies.
This is a relaxation for exporters. Notice how they MAY replace those values, but we do not allow them to drop them. So if they choose not to exercise the MAY, the "
null
values within arrays MUST be preserved as-is" applies.That is how I read it, and I'm pretty sure that's how it was meant originally (CC @arminru). But it could be worded more clearly.