Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LabelSet #560

Merged
merged 7 commits into from
Apr 14, 2020
Merged

Remove LabelSet #560

merged 7 commits into from
Apr 14, 2020

Conversation

c24t
Copy link
Member

@c24t c24t commented Apr 9, 2020

Following open-telemetry/oteps#90.

@jmacd please check my work here, I may have mangled some of your go examples.

jmacd
jmacd approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The api-user.md file is so old that I had to stop looking carefully. I'd like to get this in quickly and continue editing the metrics API spec in future PRs. Thanks!

specification/metrics/api-user.md Show resolved Hide resolved
specification/metrics/api-user.md Outdated Show resolved Hide resolved
specification/metrics/api-user.md Outdated Show resolved Hide resolved
@c24t
Copy link
Member Author

c24t commented Apr 9, 2020

Thanks for the quick reviews, hopefully this change is still worth making even if the whole file will be overhauled soon.

arminru
arminru approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR includes a lot of changes where unrelated line breaks were moved to different positions which makes it hard to spot where content was actually altered or just moved to another line. Please try to avoid this to make reviewing easier. Thanks!

We actually settled for soft breaks a while ago (#192 (comment)) but I also usually keep the style already in place in existing documents.

specification/metrics/api-user.md Outdated Show resolved Hide resolved
@jmacd
Copy link
Contributor

jmacd commented Apr 10, 2020

Re: line-breaks
Many of these are my doing. I didn't realize there was a soft-breaks policy. @c24t should we remove hard line-breaks in a separate PR across the metrics specs (or the whole repo)?

@c24t
Copy link
Member Author

c24t commented Apr 10, 2020

Sorry about the line breaks @arminru, I re-wrapped paragraphs I edited which made for a lot of spurious line diffs.

should we remove hard line-breaks in a separate PR across the metrics specs (or the whole repo)?

I'd be happy to, I'll put up a PR.

@jmacd
Copy link
Contributor

jmacd commented Apr 13, 2020

May we merge this ahead of adding soft-breaks everywhere?
I'm feeling like drafting spec changes to help push open-telemetry/oteps#93 and open-telemetry/oteps#96 forward, but I'd like this merged first.

@jmacd jmacd added the spec:metrics Related to the specification/metrics directory label Apr 13, 2020
@bogdandrutu bogdandrutu merged commit 46fd2dc into open-telemetry:master Apr 14, 2020
@c24t c24t deleted the scrub-labelset branch April 14, 2020 02:58
@c24t c24t mentioned this pull request Apr 14, 2020
Closed
@arminru arminru added this to the v0.4 milestone May 5, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@c24t @arminru @bogdandrutu
Remove LabelSet (open-telemetry#560)
123f3a8 
* Scrub LabelSet references

* Update metrics API TOC

* Remove more references to "label sets"

* Lint

* Update go examples for @jmacd's comments

* Update specification/metrics/api-user.md

Co-Authored-By: Armin Ruech <[email protected]>

Co-authored-by: Armin Ruech <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@arminru arminru arminru approved these changes

@jmacd jmacd jmacd approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@reyang reyang Awaiting requested review from reyang

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@tedsuo tedsuo Awaiting requested review from tedsuo

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@c24t @jmacd @bogdandrutu @arminru @lzchen