-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tracer to add ignored parents as links as an option, add initial semantic conventions for links #436
Closed
Closed
Make tracer to add ignored parents as links as an option, add initial semantic conventions for links #436
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Link Conventions | ||
|
||
This document is about standard attributes for | ||
[Links](api-tracing.md#add-links). | ||
|
||
## Document conventions | ||
|
||
Attributes are divided into groups, describing certain characteristics of a | ||
link. Attributes in each group start with a specified prefix and a dot. | ||
|
||
Attribute groups in this document have a **Required** column. If a link has at | ||
least one attribute from the group, then it MUST also contain all the required | ||
attributes of the group. | ||
|
||
## Link types | ||
|
||
* [Ignored parent](#ignored-parent) | ||
|
||
### Ignored parent | ||
|
||
**Prefix:** parent | ||
|
||
**Description:** These attributes are used to denote a span context that was | ||
ignored during a span creation as a parent and thus became only linked to the | ||
span. | ||
|
||
| Attribute | Description | Example | Required? | | ||
|---|---|---|---| | ||
| parent.kind | Kind of ignored span context. It MUST be either "local" or "remote". "local" denotes a span context that was a part of a current span at the time of a creation of the link. "remote" denotes a span context that was a part of remote span at the time of a creation of the link. | "local" | Yes | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another option may be to add
traceparent
of the ignored parent to thetracestate
. It may be more involved design as we will need to decide how thekey
intracestate
will be called and how to write the originaltraceparent
value there.What scenario do you envision here? Can it be implemented via the SpanProcessor so customer may apply some custom logic like I described with the
tracestate
?